]> git.koha-community.org Git - koha.git/commit
Bug 18897: Use Module::Load::Conditional::can_load
authorMark Tompsett <mtompset@hotmail.com>
Fri, 1 Sep 2017 18:15:44 +0000 (14:15 -0400)
committerFridolin Somers <fridolin.somers@biblibre.com>
Tue, 3 Oct 2017 15:00:03 +0000 (17:00 +0200)
commit088e332760b55c6f7a44097d8ab5d84003d8f0e0
tree6911f845cef3f7abd30900d29d5031ef0e71b4b1
parenta24ac206701bdde509baf47f005aa31bf42a1b6a
Bug 18897: Use Module::Load::Conditional::can_load

Rather than rely on eval(), Jonathan Druart recommended in
comment #6 to use Use Module::Load::Conditional::can_load.
This addresses that concern.

TEST PLAN
---------
$ git fetch
$ git checkout -b bug_18897 origin/master
$ git bz apply 18897
$ sudo apt-get remove libcatmandu-store-elasticsearch-perl
...
$ prove t/db_dependent/Koha_Elasticsearch_Indexer.t
-- Note that the message says the correct library is missing.
$ sudo apt-get install libcatmandu-store-elasticsearch-perl
-- Note it runs as expected.
run the koha qa test tools

Signed-off-by: Lee Jamison <ldjamison@marywood.edu>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
t/db_dependent/Koha_Elasticsearch_Indexer.t