Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch
authorBenjamin Rokseth <benjamin.rokseth@kul.oslo.kommune.no>
Tue, 1 Apr 2014 12:07:59 +0000 (14:07 +0200)
committerKatrin Fischer <katrin.fischer.83@web.de>
Fri, 21 Apr 2017 22:39:54 +0000 (00:39 +0200)
commit35c68e61b6e690e489f806c35af42be84232184f
treee7dcb98ff0a3aba80bb0186bb8aeccb5665b9c1d
parent7d286ab1021f8d403a99bbe92c8e46898bdbb2a0
Bug 12021 - SIP2 checkin should alert on transfer and use CT for return branch

This small patch corrects the SIP2 checkin response if branch transfer is needed.
It depends on bug 7981 and also removes an obsolete alert check in SIP2.

Test plan:
 - apply bug 7981
 - make sure syspref AutomaticItemReturn is false
 - check 'Return policy' in 'Default checkout, hold and return policy'
 - make a SIP2 checkout and checkin from a branch different than item's home branch.
 - verify that SIP2 response gives alert CV04 (=send to different branch)
 - also verify that response field CT gives correct branch according to 'Return policy'

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Followed test plan, works as expected
Signed-off-by: Marc VĂ©ron <veron@veron.ch>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 37836951d38ed57c7ed5ed702aab1433729ffe0d)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
C4/SIP/ILS/Transaction/Checkin.pm
C4/SIP/Sip/MsgType.pm