]> git.koha-community.org Git - koha.git/commit
Bug 31160: Required fields in patron api
authorMatt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Thu, 24 Nov 2022 15:37:51 +0000 (15:37 +0000)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Thu, 15 Dec 2022 13:31:52 +0000 (13:31 +0000)
commit49d8f8bffb3abf5995a54d479015ed2ab92dfb8e
treeb7a5d8455387d6244c35cac1c543a38d9ba4792c
parent5bd6dfcc59e5daaf43735f8b3f611bd18a90bd23
Bug 31160: Required fields in patron api

The Patron API PUT request required the fields "surname","address","city",
"library_id","category_id". Meanwhile the CSV import page for patrons only
requires "surname","library_id","category_id". The fields for "address" and
"city" have been removed from the "required" section of the api > v1 > swagger
> definitions > patron.yaml file to match the CSV import page.

Test Plan:
1) Send a PUT request to http://localhost:8081/api/v1/patrons/19 with an empty body
2) Error message should ask for 5 missing fields as listed above
3) Apply patch
4) Restart Apache server using "restart_all" in your ktd shell
5) Resubmit your request
6) Error message should now only request "surname","library_id","category_id"

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 1d522cc2464ac0d953e93d3f8f178da1a9e06d82)
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
api/v1/swagger/definitions/patron.yaml