]> git.koha-community.org Git - koha.git/commit
Bug 9667 - Inventory scrolling to top with every click
authorOwen Leonard <oleonard@myacpl.org>
Mon, 14 Jul 2014 13:05:05 +0000 (09:05 -0400)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Fri, 25 Jul 2014 22:05:03 +0000 (19:05 -0300)
commit564018291e17698aace4f4048b2e3a4875b443e2
treeb196962344016148ef52be3e2e03a3c638d6b27d
parente86387eee2a6d60d36e5dd22322d06b8be5c91bd
Bug 9667 - Inventory scrolling to top with every click

An "onclick" attribute on inventory results links causes the page to
scroll to the top each time. This patch updates the click handling to
use a progressive-enhancement method.

Unrelated changes: I added use of the Branches T:T plugin to output
library name instead of branchcode, and put a check around call number
to prevent output of empty [] in results.

To test, use the inventory tool to check a batch of items. On the
results page:

- Confirm that branch name is shown instead of code.
- Confirm that no [] shows for items without call numbers
- Confirm that clicking a title opens a pop-up window showing details
  for that title.
- Confirm that clicking a title opens a pop-up window whether you're on
  the first page of results or any subsequent page.

Signed-off-by: Ian Beardslee <ian@catalyst.net.nz>
Tested in Firefox and Chromium.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt