Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Thu, 11 Mar 2021 15:11:15 +0000 (16:11 +0100)
committerAndrew Fuerste-Henry <andrew@bywatersolutions.com>
Sat, 24 Apr 2021 15:45:32 +0000 (15:45 +0000)
commit5ef04da9743ea09e842de1bcfd5740a386d65205
tree4b6b7280924e643a6c75aa222f2d2c08c84191b6
parent20d66fdfd6736e09ffbbe2ee55be6a295c0c5fad
Bug 27921: Log correct timestamp for HOLD MODIFY when set waiting

The HOLD MODIFY log at the end of ModReserveAffect is not using an
up-to-date $hold object.

$hold is modified at
1201         $hold->set_waiting($desk_id);
But not refreshed before logged (and so the timestamp is not logged
correctly).

Test plan:
Turn on HoldsLog
Place an item on hold
Check it in to mark it waiting

Confirm that the timestamp logged is the one from the check in, not when
you created the hold

Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit cb03909af62585aa7a280cd49b2008b0e7b2cbb8)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 66a698fc7248750b8fda96241db7dcf8883b125b)

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
C4/Reserves.pm
t/db_dependent/Reserves.t