]> git.koha-community.org Git - koha.git/commit
Bug 29962: (bug 27526 follow-up): Fix columns button on item list
authorJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 28 Jan 2022 08:49:44 +0000 (09:49 +0100)
committerKyle Hall <kyle@bywatersolutions.com>
Fri, 25 Feb 2022 13:32:30 +0000 (08:32 -0500)
commit61b82c556eb02d89063d22f05f73fc0ec14a41b2
tree9502f0513a1c55d4fb349a85b654ba8eebdebba7
parent140f8e032bac9c510cc718341fd16f3db335b467
Bug 29962: (bug 27526 follow-up): Fix columns button on item list

The "Columns" button on the item list view has been broken (hidden) by
bug 27526.
"column_name" was removed from the item_header_loop:
-    if ( $kohafield && $kohafield =~ /items.(.+)/ ) {
-        $header_value{column_name} = $1;
-    }

We can still access the attribute name using 'attribute' however.
The difference is that non-mapped subfield will have an "attribute", but
there is a net to prevent a crash in columns_settings.inc:
 12         var named_id = $( 'thead th[data-colname="' + this.columnname + '"]', selector ).index( selector + ' th' );
 13         var used_id = dt_parameters.bKohaColumnsUseNames ? named_id : counter;
 14         if ( used_id == -1 ) return;

We should simply pass attribute.

Test plan:
Create a non-mapped subfield (952$k)
Edit an item, add a value for k
On the item table at the top of the edit form notice that the "Columns"
button is back and that it's working correctly.
Note that 'k' cannot be hidden (may be considered as a bug, but it's not
a regression).

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt