Bug 33375: Quote reserved keyword 'rank' in advanced editor
authorDavid Cook <dcook@prosentient.com.au>
Fri, 31 Mar 2023 00:55:56 +0000 (00:55 +0000)
committerArthur Suzuki <arthur.suzuki@biblibre.com>
Tue, 23 May 2023 18:43:31 +0000 (20:43 +0200)
commit6bc5310c4420b8ed5c5d789452642af4d2f27d25
treedc7b530cfb11a8534ceb515351b4a844548c41ae
parent01ce75498b69c9586cd9327644edb37fa9af4ea4
Bug 33375: Quote reserved keyword 'rank' in advanced editor

This change quotes the 'rank' keyword in the advanced editor,
so that it doesn't cause fatal crashes when using MySQL 8

Test plan:
0. Apply patch and koha-plack --restart kohadev
1. Enable advanced editor
http://localhost:8081/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=EnableAdvancedCatalogingEditor
2. Go to http://localhost:8081/cgi-bin/koha/cataloguing/editor.pl#new/
3. Click on "Advanced" on the left nav
4. Note that "LIBRARY OF CONGRESS" is ordered before "NATIONAL LIBRARY OF FRANCE"
5. Rejoice!

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit 99f8273673b7e2189fff5846bdeacff70e0a48ed)
Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
(cherry picked from commit 30260ece2f567823da7189abf5ebd0a43caa526a)
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
(cherry picked from commit d7b5cbf075241f84d06edaa08f40b129229a80c5)
Signed-off-by: Arthur Suzuki <arthur.suzuki@biblibre.com>
cataloguing/editor.pl