Bug 34859: Remove unnecessary params from reports-home.pl
authorDavid Cook <dcook@prosentient.com.au>
Thu, 21 Sep 2023 01:27:45 +0000 (01:27 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 4 Oct 2023 20:40:16 +0000 (16:40 -0400)
commit7382e305e1bc6c43c74397f135e2267fcb9f8e4e
tree0ba0a62da0637d1acaca37de50d36da9b68e6f7f
parentc9ab718a39174d0a874fc8de8964b6f96b704f37
Bug 34859: Remove unnecessary params from reports-home.pl

This change removes unnecessary syspref template parameters
and tidies the code.

Test plan:
0. Apply the patch and koha-plack --reload kohadev
1. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=IntranetNav
2. Add the following and save:
<li><a href="#">Awesome</a></li>
3. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetstylesheet
4. Add the following and save:
http://bad
5. Go to
/cgi-bin/koha/admin/preferences.pl?op=search&searchfield=intranetcolorstylesheet
6. Add the following and save:
http://bad2
7. Go to /cgi-bin/koha/reports/reports-home.pl
8. Note the "Awesome" link in the top navbar
9. Note in the console that there are two errors where http://bad
and http://bad2 can't be resolved

Signed-off-by: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
reports/reports-home.pl