Bug 11505: fix untranslatable table headers in Label batch manager
authorOwen Leonard <oleonard@myacpl.org>
Fri, 10 Jan 2014 20:46:29 +0000 (15:46 -0500)
committerChris Cormack <chrisc@catalyst.net.nz>
Mon, 24 Mar 2014 04:35:55 +0000 (17:35 +1300)
commit792e1b6259af8da6067a86263ecd4f197ffd5295
tree8987ec1c2f4625c46910c20d8b4a064936c940b2
parenta80918f76d83c548999c4726959d932a6452fc87
Bug 11505: fix untranslatable table headers in Label batch manager

The label batch manager script hard-codes the table header cell labels
in order to pass them to an HTML-building function. This obviously isn't
the best solution for internationalization, but picking the whole scheme
apart would be very complicated.

Instead this patch uses a SWITCH statement to check for each possible
case and outputs the correct translatable string for each.

To test, apply the patch and run "perl translate update" for any
translation. Check the revised po file and confirm that the new strings
are present. View the label batch edit page and confirm that the table
headings look correct: Tools -> Labels -> Manage batches -> Edit batch.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests.
Similar fixes are probably needed for other pages of the labels
modules.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit e8f5ee9eef7a558ae1af8237493f8dc52e52945a)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
koha-tmpl/intranet-tmpl/prog/en/modules/labels/label-edit-batch.tt