]> git.koha-community.org Git - koha.git/commit
Bug 25747: Don't display a comma when patron has no firstname
authorOwen Leonard <oleonard@myacpl.org>
Mon, 15 Jun 2020 11:14:22 +0000 (11:14 +0000)
committerLucas Gass <lucas@bywatersolutions.com>
Fri, 10 Jul 2020 16:30:27 +0000 (16:30 +0000)
commit7d4d03d1bef5e14760e0ea639a8edeb796c633a7
treef72066b4b26bb28761752d9815b0efe50613fe9b
parent773dd857eed7e6eca01a8c098b973e20356157a3
Bug 25747: Don't display a comma when patron has no firstname

This patch adds a check for the existence of "firstname" to
patron-title.inc so that if the patron has no firstname the "invert
name" setting doesn't cause an unnecessary comma to appear.

To test, apply the patch and locate or create a patron with no first
name.

- When checking out to the patron, examine the page title. It should say
  "Checking out to <lastname> (<cardnumber>).
- When checking out to a patron with first and last name it should show
  as before, "Checking out to <lastname>, <firstname> (<cardnumber)

Signed-off-by: Sally <sally.healey@cheshiresharedservices.gov.uk>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit d2f136713e814d4e33e18d1cdad88f3675a9ec3a)

Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
koha-tmpl/intranet-tmpl/prog/en/includes/patron-title.inc