Bug 33608: Polish Koha::Statistic further
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 8 May 2023 09:17:32 +0000 (09:17 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Wed, 25 Oct 2023 14:07:56 +0000 (11:07 -0300)
commit917e3283411d8a25d86ed57a470ce6d224365a24
tree9b83757688bbe56dca586643982850fca2a7d837
parent7ceb3959c3a715afff1939f71059d7aa60be8c4e
Bug 33608: Polish Koha::Statistic further

Adding exceptions, removing croaks.
No exception in new for unknown hash keys, store will catch that.
Prepare switching amount parameter to value (db column name).

Test plan:
Run t/db_dependent/Stats.t
Run t/db_dependent/Koha/Items.t

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Owen Leonard <oleonard@myacpl.org>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
[EDIT] Fixed the mandatory check in Stats.t. Removed key_or_default.
       Additional tidy.

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Statistic.pm
t/db_dependent/Stats.t