Bug 15504: (QA follow-up) Final changes
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Thu, 12 Oct 2023 07:35:58 +0000 (07:35 +0000)
committerTomas Cohen Arazi <tomascohen@theke.io>
Tue, 24 Oct 2023 13:05:23 +0000 (10:05 -0300)
commita939f8da154cd6e28a8edabe2aba709f082d74c4
tree867f007bf547644f79c2de94e55ce934a7d0122c
parent7a91be18148b1e9449837ff9efc77fef9b024be7
Bug 15504: (QA follow-up) Final changes

[1] Comment in Patron->is_active sharpened.
[2] Patron->update_lastseen
      return if $cached && $cached eq $now->ymd;
    Should be
      return $self if $cached && $cached eq $now->ymd;
    Consistent return value.
[3] Typo if there are not TrackLastPatronActivityTriggers enabled
[4] Typo TrackLastPatronActivityTriggers must be contain
[5] Typo patron is does .. option => performs an action
[6] Tidy on dbrev to fix
      The file is less tidy than before (bad/messy lines before: 0, now: 4)

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Koha/Patron.pm
installer/data/mysql/atomicupdate/bug_15504-add-tracklastpatronactivityoptions.pl
installer/data/mysql/mandatory/sysprefs.sql
misc/cronjobs/delete_patrons.pl