]> git.koha-community.org Git - koha.git/commit
Bug 22284: Control hold groups in C4::Reserves
authorAgustin Moyano <agustinmoyano@theke.io>
Mon, 25 Mar 2019 03:45:58 +0000 (00:45 -0300)
committerMartin Renvoize <martin.renvoize@ptfs-europe.com>
Fri, 3 Jan 2020 12:58:03 +0000 (12:58 +0000)
commita998ba5714c8dc1b78062e95bd78e2738112737d
treea53a2931d91a8376095432d109ae2c7a1d2a622e
parent8141ebbac6e65f7c76a9ec70ab7329564404b738
Bug 22284: Control hold groups in C4::Reserves

This patch modifies C4::Reserves to control when hold group options where selected
in smart rules.
In CanItemBeReserved adds 2 new error status messages
1) branchNotInHoldGroup: when a patron's homebranch is not in item's hold group
2) pickupNotInHoldGroup: when a selected pickup location is not in item's hold group
Also CheckReserves is modified when item's priority is defined, to control by hold
group when required.
Finally, IsAvailableForItemLevelRequest was also modified to control by hold group when
required.

To test:
1) Apply this patch
2) prove t/db_dependent/Holds.t
SUCCESS => Result: PASS
3) Sign off

Sponsored-by: VOKAL
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Liz Rea <wizzyrea@gmail.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
C4/Reserves.pm
t/db_dependent/Holds.t