Bug 19076 - Move issue logging in AddIssue into condtional clause
authorNick Clemens <nick@bywatersolutions.com>
Thu, 10 Aug 2017 15:20:58 +0000 (15:20 +0000)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Fri, 1 Sep 2017 16:02:27 +0000 (13:02 -0300)
commitb66b86402cd84026f7dabaa2e567a1956b9bbe86
tree2bee5b0538bb117202012d4e46d0b97579b7c78f
parent8901f5702a7c6755c1f84cde01d75765687bb060
Bug 19076 - Move issue logging in AddIssue into condtional clause

Currently AddIssue tests if renewal, but logs an issue even if so. This
patch moves the logging into the conditional so a log entry is only
added if we aren't renewing (as renewals are logged separately)

To test:
1 - prove t/db_dependent/Circulation.t - one test should fail
2 - Enable both issue and renewal logs
3 - Checkout an item to a patron
4 - View the logs - the issue is captured
5 - Checkout the item to the patron again and confirm renewal
6 - Both an issue and a renewal are logged
7 - Apply patch
8 Repeat 1-6, tests should pass and only renewal should be logged

Signed-off-by: Julian Maurice <julian.maurice@biblibre.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
C4/Circulation.pm