Bug 29255: Built-in offline circulation broken with SQL error
authorOwen Leonard <oleonard@myacpl.org>
Fri, 15 Oct 2021 18:27:16 +0000 (18:27 +0000)
committerVictor Grousset/tuxayo <victor@tuxayo.net>
Sun, 21 Nov 2021 21:42:26 +0000 (22:42 +0100)
commitb735313017f574cd0bec35f38d8f824c709ec7f5
tree20588f19e4e37b9992e80d00d5a6f031d199b467
parentac2ece17bd0de3a37c2095556eacfe95071d0af3
Bug 29255: Built-in offline circulation broken with SQL error

This patch makes a minor correction to one of the queries used when
synchronizing transactions in the built-in offline circulation system.
This fixes the error:

DBD::mysql::st execute failed: Column 'branchcode' in field list is
ambiguous at /kohadevbox/koha/offline_circ/download.pl line 84

To test you must be using a browser which still supports
applicationCache (Firefox before version 81, Chrome before version 94).

- Apply the patch and restart services.
- Enable the AllowOfflineCirculation system preference.
- Go to Circulation -> Built-in offline circulation interface.
- Click "Synchronize."
- Click the "Download records" button.
- After the page refreshes you should see updated dates where it lists
  "last synced" information.

Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Joonas Kylmälä <joonas.kylmala@iki.fi>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit 6501ff67ac1b7942f424bed458314efb0132bd68)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 7f21bd6a5e796bc5358c98448181d3e779f7a8c5)
Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
offline_circ/download.pl