]> git.koha-community.org Git - koha.git/commit
Bug 26996: Convert Elasticsearch indexer commit buffer size to integer
authorBjörn Nylén <bjorn.nylen@ub.lu.se>
Wed, 11 Nov 2020 07:35:21 +0000 (08:35 +0100)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Mon, 4 Jan 2021 12:29:55 +0000 (13:29 +0100)
commitba9c9cc794123d60c92a4ce499aa4554299936b6
tree3c829a7564c529c83b9c831db21a061a332621c9
parentf0209415245fec941f44ed40ee47d8f163e5bb48
Bug 26996: Convert Elasticsearch indexer commit buffer size to integer

When multithreaded indexing is used, the commit size for children are spread
out resulting in them being of type float. When records are processed and the
commit counter decreased it may then never reach *exactly* 0. This means records
are never commited. This patch makes sure the counter is an integer to avoid the
problem.

To test you must find a set of circumstances that causes the issue. For me:
1. Run: ./rebuild_elasticsearch -v -b -p 2 -c 400
2. Note that only one process is logging "Committing xxx records..."
3. Kill processes.
4. Apply patch.
5. Repeat 1
6. Note that both processes are logging "Committing xxx records..."

Sponsored-by: Lund University Library
Signed-off-by: Joonas Kylmälä <joonas.kylmala@helsinki.fi>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
misc/search_tools/rebuild_elasticsearch.pl