]> git.koha-community.org Git - koha.git/commit
Bug 11391: drop default value on suggestions.suggesteddate column
authorGalen Charlton <gmc@esilibrary.com>
Fri, 13 Dec 2013 01:06:12 +0000 (01:06 +0000)
committerFridolin SOMERS <fridolin.somers@biblibre.com>
Fri, 3 Jan 2014 08:32:32 +0000 (09:32 +0100)
commitd69c1a367b79a8f62192994a39c3528e6783b0f9
treedbc69220dd6007ec0baec875f0ec417a29f9e00f
parent808e0f46f2b87036812788b6d32835244607e329
Bug 11391: drop default value on suggestions.suggesteddate column

The 'default 0' clause got translated as an invalid constant
default of '0000-00-00' when DBIx::Schema is used to deploy
the suggestions table into a Pg database.  This patch drops
the default.

To test:

[1] Apply the patch and run the SQL specified in the database
    updated.
[2] Verify that the suggestions table no longer has an
    explicit default value for the suggesteddate column.
[3] Verify that prove -v t/db_dependent/Suggestions.t
    passes.
[4] Verify that installer/data/mysql/kohastructure.sql runs
    cleanly in an empty database.
[5] Verify that there are no visible regressions of the
    purchase suggestions functionality.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Having a default of 0 on a date seems like a mad thing to do anyway,
so good to get rid of it

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit a6b2f6a16175229ba603ed65cfeaf4e0c0a525ce)
installer/data/mysql/kohastructure.sql
installer/data/mysql/updatedatabase.pl