Bug 34365: Add cancellation request flow to DELETE /holds
authorTomas Cohen Arazi <tomascohen@theke.io>
Mon, 24 Jul 2023 19:08:50 +0000 (16:08 -0300)
committerPedro Amorim <pedro.amorim@ptfs-europe.com>
Fri, 18 Aug 2023 13:32:20 +0000 (13:32 +0000)
commitd7b6d7b4487b7fbf5d3835a9bdd08518c06c44fa
tree6ce1df0c4473ee954ef05549636f52f42cdb2a97
parentf940a143312805110c9245f7cb884ccdaad310a5
Bug 34365: Add cancellation request flow to DELETE /holds

This patch adds a new `x-koha-override` header to allow enforcing the
cancellation request flow for waiting holds.

If the hold is not waiting, the header has no effect.

To test:
1. Apply the tests patch
2. Run:
   $ ktd --shell
  k$ prove t/db_dependent/api/v1/holds.t
=> FAIL: The endpoint doesn't implement the required logic
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass! The endpoint behavior is changed!
5. Sign off :-D

Signed-off-by: Emily Lamancusa <emily.lamancusa@montgomerycountymd.gov>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
(cherry picked from commit eb224540e223d71f1f494b94ce3442567a1c6664)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit e4e145eb4ad61db989395e45dbe082c0df7feff4)
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com>
Koha/REST/V1/Holds.pm