]> git.koha-community.org Git - koha.git/commit
Bug 16202: GetIssuingCharges should return a collectable amount
authorColin Campbell <colin.campbell@ptfs-europe.com>
Tue, 5 Apr 2016 11:56:24 +0000 (12:56 +0100)
committerKyle M Hall <kyle@bywatersolutions.com>
Fri, 3 Mar 2017 19:24:27 +0000 (19:24 +0000)
commitd84ed89557e2c921f261b1c620434d432dcbd3f7
tree702682a73eb4dd22ad6ca2336d8f1bf36062b60f
parent7a5f17ff6ecbec3a7f73fa54b900dae909996b29
Bug 16202: GetIssuingCharges should return a collectable amount

Charges should not include elements less than a penny/cent
they are not displayed but can be saved to the database
causing "odd" behaviour down the line

Make the routine round the resultant charge to nearest cent,
so consistent values are returned.
Removed the one case where it was rounded post call.
Although the main danger is values generated by the discount
calculation apply the rounding to all returned charges in case
the item charge is defined using the 3rd or 4th decimal
places.

NOTE: prove -v t/db_dependent/Circulation.t triggers the change.
      Though, all the returned amounts are 0.00 only.

Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
C4/Circulation.pm