]> git.koha-community.org Git - koha.git/commit
Bug 9113: fix handling of certain characters by item batch modification tool
authorFridolyn SOMERS <fridolyn.somers@biblibre.com>
Wed, 26 Jun 2013 15:52:40 +0000 (17:52 +0200)
committerTomas Cohen Arazi <tomascohen@gmail.com>
Mon, 15 Jul 2013 23:24:21 +0000 (20:24 -0300)
commitdbd52acf2958bca6b126a35a47d03b6d4d4d541d
tree1a7b016e4af16064f9a7e21ef3f5a0e2ec58f5e5
parent7c92496cf7f7ee1016b934a8e01e995b680f9761
Bug 9113: fix handling of certain characters by item batch modification tool

If you're using the batch modification tool and entering a call number
like "E+ 123 ABC", the tool removes the + and puts a space in its place,
e.g., "E  123 ABC"

This is because the form is posted via Ajax by background-job-progressbar.js.
Values are URI-encoded using escape(), but this method does not escape some
characters: * @ - _ + . /

Also, "+" is considered as a space in a URI.

This patch replaces escape() by encodeURIComponent() which encodes every character.

Test plan :
Perform an items batch modification by setting '* @ - _ + . /' in a field
(notes for example) and see that all characters are saved correctly.

Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 0397e7ea64c208c140d7178ed34c3bd4b266fcfb)
Signed-off-by: Tomas Cohen Arazi <tomascohen@gmail.com>
koha-tmpl/intranet-tmpl/prog/en/js/background-job-progressbar.js