(BUG #4346) replaces Basket grouping by Basket groups in acquisitions-toolbar.inc

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Refactor for Human Readability

Fixes  generation of empty index page when total_parcels is a multiple of pagesize
Remove some calculations whose results were not used
Make variable names meaningful (results and count arnt)
Fix errors in pod syntax
Make what code does clearer to readers who are not computers
Use a subroutine

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4331 Remove cruft from acqui-home script

Remove unnecessary db calls and processing from acqui-home.pl
Do not duplicate processing of fields
Declare variables closer to use
Remove unnecessary holding vars
Replace some anonymous var names by something more meaningful
Do not generate a toggle variable use Template's LOOP vars

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4331 Index aqorders by budget_id

Calculation of budget spent and encumbered is done by
queries on aqorders by budget_id
Index budget_id to speed these queries

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for ampersand display problem in OPAC search results

This is a quick fix to XSLTParse4Display to make ampersands display
correctly in OPAC search results.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

MT3204 : Fix unstranslatable strings in JavaScript

For an explanation, see:

http://wiki.koha.org/doku.php?id=en:development:codingguidelines#translatable_text

This bug blocks entirely serials module. It isn't possible
to create/edit a subscription. Brocken JavaScript prevents
Search for a vendor and Search for Biblio dialog box
to pop-up.

Problem with new strings and new html tags inside the strings
this patch removes them

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixes bug 4365 hidelostitem syspref language reversed

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

tweak display of issuing library on staff reading history

Following idea in patch submitted by Kyle Hall on 1 April 2010,
use issues.branchcode instead of issues.issuingbranch to set
displayed issuing library.  Also tweaked wording.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4375 - update koha link on auth template

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix POD for GetAllIssues

Please remember to update the POD if you change a
core function.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4358: remove disused ReadingHistory syspref and related code

The ReadingHistory sytem preference is no longer used, and possibly
was used by only one library anyway.  Removed references to it; note
that had it been turned on, a patron viewing checkout history would have
seen old loans showing up twice.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug Fixing opac/opac-readingrecord.pl

There was some rebase issues on this script
Fixing Error 500
two calls to $issues as an array ref where it is now a hash ref

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(bug #4358) fix sql query in C4::Members::GetAllIssues

This fix the use of oldissues instead of old_issues table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

[MT3191] follow-up, removing warn

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

[MT3191] various perl errors in script (merge conflict)

and SQL error solved

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

[MT2195] Display issuing branch in reading record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Followup (MT #2920) fix reading record scripts:members/readingrec.pl

Fixing Merge problem on opac/opac-readingrecord.pl

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT #2920) fix reading record scripts

This patch fix some perl ugly code to be more readable and lesser complex.
And it allow in intranet to order by issues.timestamp.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

[MT2358] Display issue date in member reading record

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4322 update typos on web services preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Update copyright license to GPL version 2 or later for two cronjobs.

See http://lists.koha.org/pipermail/koha-devel/2010-March/011067.html
for confirmation that this is OK.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Trapping fatal error that occurs if you call GetCOinsBiblio with a biblionumber that doesn't exist in the Koha database

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4317 fix typo in cataloging plugin

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

update patron help files

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Lower dependency on Storable to 2.20.

The Debian squeeze system has only 2.20, and the 2.21 does not
seem to be required for all tests to pass. Also, checked with
Galen Charlton and Henri-Damien LAURENT (who added the 2.21
dependency) on IRC that 2.21 did not have anything that was
required, compared to 2.20.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4361 Return Patron Expired to Sip Process

Identify Patron Expiry so that it is returned in Patron Info Response

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4364 - SIP Checkout dates incorrect

Change timestamp routine to do the right thing when passed an iso date
Otherwise was generating an epoch date of 0

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

SIP Patron management

Using Flag EXPIRED to notice whether Patron CAN or CANNOT checkout a book

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 2653 Protect against sending End of Message in Text

Remove any carriage returns in text data as they will be
interpreted as end of message by clients and cause communication failure

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Updating history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Adding when software.coop started supporting Koha to the history

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix typo in variable name

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

text for SCO Finish button

Simplifying finish button on SCO screen: it was a long sentence with a button saying "click here if you're done". Changed to "Finish". Changed the help accordingly.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Escape input that goes in HTML; Reworked search history insert SQL

Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 4244, Use "checkouts" instead of "issues"

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 3663 current head version changes to OPAC advanced search

Copy Search button to top of screen, rearrange order of indexes in search
pulldown list (to Keyword, Title, Subject, then Author & the rest)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT #2962) add converted chars from ISO5426

This add 0xBE and 0xBD conversion to char table.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT #3075) fix oe char from iso5426

this add oe conversion in chartable for iso5426.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Using only default framework for koha2marclinks

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4291 - template edits to koha to marc mapping

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Improve display of information on Transfers to your library report

- Use GetRecordValue() to show subtitle
- Show author
- Separate branch and call number display for better sorting
- Correct teriminology (reserve -> hold)

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4316: Fixes leading and trailing spaces in barcode for cki.

Copies the regexp from circulation.pl to strip leading and trailing spaces from barcodes to returns.pl.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixes for syndetics, some variables needed by the template were not being set

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 4301, OPAC RSS feed link doesn't include sort parameter

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix for Bug 4296, label search printing titles between buttons

- Reformating display for readability
- Converting select/clear all buttons to links to match existing patterns
- Fixing "Results x of x" display which was broken for single-page sets

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

additional improvement to POD for CanBookBeIssued()

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix pod documentation for CanBookBeIssued method to refer to the right variable.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4190: messages in patron account did not work with branchcodes >4

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixed an encoding bug in the documentation

Moved the binmode pragma to the end of the file, so it won't affect documentation templates. So no more double encoding.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixed an encoding bug in the documentation

Moved the binmode pragma to the end of the file, so it won't affect documentation templates. So no more double encoding.

Signed-off-by: Henri-Damien LAURENT <henridamien.laurent@biblibre.com>
Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix syntax error present in previous ILS-DI patch series

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bump DBrev to 126

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

C4/ILSDI/Services.pm Fixing rebasing and merge problems

Previous patches introduced many merge conflicts.
This patch fixes them all

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

(MT 2563) : ILSDI PatronLookUp Problem

owed to the change in C4::Members API, GetMember had to be adapted

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

ILS-DI Messages uniformization

[MT2306_2271] ILS-DI Message codes consistence

The services now returns ILSDI error codes in a <code> tag, plus details in a <message> tag.

Exemple:

<LookupPatron>
<code>MissingParameter</code>
<message>The required parameter patron_id is missing.</message>
</LookupPatron>

[MT2306_2271] Minor changes in HTML

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

ILS-DI Code cleaning

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fixes access permissions to ILS-DI

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Followup adding ILS-DI System-preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4194 : Adding ILS-DI System preferences

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Bug 4314 Flag for SSL Enabled to fix 3rd Party Enhanced Content in OPAC

Duplicates gmcharlt's earlier change to Auth.pm to add a check for SSL-enabled.
Modifies the various template calls to Syndetics and Library things to use an
https URL if SSL is in use.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 4314: add using_https environment variable

Added new HTML template variable, using_https, for use
of OPAC or staff-side templates that may need to know
whether to use http:// or https:// links to off-site
content.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

fix typos in history.txt

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

History update

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory C4/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory cataloguing/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory patroncards/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory reports/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory members/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory serials/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory misc/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory xt/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory reserve/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory opac/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory tags/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory .

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory tools/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory virtualshelves/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory t/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory svc/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory acqui/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory labels/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory installer/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory circ/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory admin/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Replace inline copy of GPL-2 with a reference to /usr/share/common/licenses.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory authorities/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory catalogue/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory install_misc/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory etc/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix copyright license statements to use the right old address for the FSF.

Looks like someone has done some search/replace on character codes with
patterns that match the address. Oops.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix FSF address in directory basket/

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Remove whitespace from ends of lines of copyright statement.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Add script to replace old FSF address on Temple Street with new one.

This assumes certain patterns for the paragraph that contains
the FSF's address. It is not a generic tool.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Add script to find source files with copyright license problems.

The files reported are those with a copyright statement, but
without a reference to the GPL2 or later, or with a non-current
FSF address.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Fix wording of 'at your option' in GPL license statement

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Update LICENSE with a fresh copy from upstream. This updates the FSF address, and refers to the LGPL with its current name, and changes a few other minor things of the typographical sort. No semantic changes.

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bug 3482: add PrintNoticesMaxLines to new syspref editor

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

bump up DBrev to 125

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>

Merge branch 'Bug3482' of git://github.com/ptfs/Koha-PTFS into to-push

* 'Bug3482' of git://github.com/ptfs/Koha-PTFS:
  Bug 3482: Updated DB version
  Bug 3482 changed name of notices file
  Bug 3482 Allow hold notices to be sent in print form
  Add expiration date, today to hold notices
  Modified to use dirspec only
  Bug 3482 Print Notices via HTML

Fixes bug 4232: Undefined hash references in Label Creator

Signed-off-by: Galen Charlton <gmcharlt@gmail.com>