Paul Poulain [Thu, 28 May 2009 16:32:14 +0000 (18:32 +0200)]
fix for 2997 : superlibrarian's ability to edit item/patron home branch affected if all other privileges are selected
Before this patch, we used to test for flags == 1, which was wrong when patron had all privileges.
This patch just adds a %2 to check that patron has superlibrarian privilege, and maybe something else we don't care.
I think I fixed it everywhere except in acquisition, that will be addressed by BibLibre new acquisition module.
Garry Collum [Thu, 28 May 2009 01:48:12 +0000 (21:48 -0400)]
Bug 2266: Could not uncollapse a tag if you turn on advancedMARCeditor - Revised.
Added javascript and if/else logic to the addbiblio.tmpl and a corresponding anchor tag in CSS.
If advancedMARCeditor is on, the user now clicks on the tag number to expand the marc fields.
If advancedMARCeditor is off, no functionality has changed. The user clicks on the marc tag's title to expand the marc fields.
Joe Atzberger [Wed, 27 May 2009 18:38:58 +0000 (13:38 -0500)]
Allow option to preserve Extended Attributes on patron import update.
Essentially, this patch provides the option to overwrite only matching
Extended Attributes, instead of all of them, treating the ext. fields more
like normal fields.
Several functions added to Members::Attributes with corresponding tests.
Galen Charlton [Wed, 27 May 2009 18:10:46 +0000 (13:10 -0500)]
bug 2642, 3263: new MARC display system preferences (DB rev 036)
* Added definitions of the new display sysprefs:
viewISBD - Allow display of ISBD view of bibiographic records
viewLabeledMARC - Allow display of labeled MARC view of bibiographic records
viewMARC - viewMARC Allow display of MARC view of bibiographic records
* Adjusted IntranetBiblioDefaultView
* made type choice (fixing bug 1933)
* added better description for English
* added labeled_marc option
Galen Charlton [Wed, 27 May 2009 18:10:42 +0000 (13:10 -0500)]
bug 3263: Staff Search Results Interface Changes
Coding by Rick Welykochy <rick@praxis.com.au>
[1] Three new system preferences to enable particular
bib record views in the staff interface:
viewMARC
viewLabeledMARC
viewISBD
Implements enhancement 2642.
[2] New button in the regular and cataloging search results
pages in the staff interface to allow the operator to redo
the search against Z39.50 targets instead of the Koha database.
[3] Added copyright date and edition to cataloging and Z39.50 search results.
Implements enhancement 2640.
Galen Charlton [Wed, 27 May 2009 14:57:24 +0000 (09:57 -0500)]
various improvements to subscription editing
* fix XHTML errors in template
* the patron notification type is now correctly
displayed when editing a subscription
* turned on warnings (bug 2505)
* added ability to modify the grace period, missed
in initial patch for bug 3020
Ryan Higgins [Wed, 27 May 2009 15:31:47 +0000 (10:31 -0500)]
bug 3244: Support for multiple PAC interfaces.
Adds three env vars allowing url-specific search limits, and defining
how the limit interacts with 'SearchMyLibraryFirst'.
See http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_multiple_opac
Updated INSTALL.opensuse file to match the one currently (as of 26-May-2009) available in the wiki at:
Installation Guide for Installing Koha 3 on openSUSE 11 - Koha Developer Wiki
http://wiki.koha.org/doku.php?id=opensuse_11.0
This commit is supposed to be applied to the 3.0.x branch.
Changelog:
– Updated last modification date to 02-Dec-2008
– Tried to clarify that one should add the word "rewrite" (without the quotes) to /etc/sysconfig/apache2 in case a2enmod does NOT work
– "make test" does NOT return "Can't connect to data source" errors any longer. Updating "make install" section accordingly
– Updated "make test" output for Koha installation (it doesn't give connect errors any longer)
– Added prompt to accept permanent instlallation of "Test-Manifest-1.22.tar.gz" during "XML::RSS" install
– Installing "XML::RSS" now also installs "Time::y2038"
– Added "force install" of "Barcode::128"
– Added output of "MARC::Charset" installation (that points that it is already up to date)
– Updated "CGI::Session::Serialize::yaml" section that now installs Test::Pod
– Added "MIME::LITE" installation that is new in Koha 3.0 Final
– Removed ImageMagick installation because it's no longer required in Koha 3.0 Final
– Added instructions to install the "GD" Perl module and its package dependencies
– Added "Email::Date" installation that is new in Koha 3.0 Final
– Updated list of prerequisites according to changes done in Koha 3.0 Final
– Added missing step to install yaz. Thanks to Bob Ewart for catching it
– Added explanation of answering Yes to "Install the Zebra configuration files" in a NOZEBRA installation, like this one
– Added explanation of "fr" (French) choice for Koha install
– Promoted run "make install" to Heading 4
Joe Atzberger [Tue, 26 May 2009 21:41:03 +0000 (16:41 -0500)]
Cleanup waitingreserves.pl and .tmpl
Use warnings and provide fallback values to avoid them.
Move waitingdate check up to top of loop.
Move $today creation outside loop (should be same for all).
Remove unused and unnecessary variables.
Add subtitle escaping to .tmpl and slightly standardize formatting.
Garry Collum [Sun, 24 May 2009 16:10:23 +0000 (12:10 -0400)]
Bug 1687: Can't assign holidays to all branches at once.
This patch adds a select box to the new holiday form that allows the user to copy the holiday to all branches. If a holiday for a particular location already exists for a location, that holiday and location is not changed.
Garry Collum [Mon, 25 May 2009 00:51:18 +0000 (20:51 -0400)]
Bug 3022: Cataloging statistic wizard not pulling the itemtype data correctly.
Added code to detect if the syspref for item-level_itypes is being used. The report now correctly returns data based on the syspref. There are some pre-existing XML errors with the FORM view of catalogue_stats.pl. I'll send a subsequent patch to deal with these.
Galen Charlton [Tue, 26 May 2009 19:20:03 +0000 (14:20 -0500)]
bug 3219: handle variation in Amazon responses
An Amazon ItemLookup response can sometimes have
more than one Item element, where the ones after
the first appear to be cross references to items
that have the same ISBN. Changed parsing so that
those responses are no longer treated like pseudohashes.
This fixes the following crash:
[error] detail.pl: Pseudo-hashes are deprecated at /catalogue/detail.pl line
213., referer: /cgi-bin/koha/catalogue/detail.pl
Which may lead to a nasty:
[error] Out of memory!, referer: /cgi-bin/koha/catalogue/detail.pl
Joe Atzberger [Fri, 22 May 2009 21:45:51 +0000 (16:45 -0500)]
Cleanup view_holdsqueue.pl and .tmpl (minor)
Convert to GetBranchesLoop.
Insert template message to display for ALL libraries search, so that the
message is n0t truncated like "X items found for".
Joe Atzberger [Fri, 22 May 2009 20:31:07 +0000 (15:31 -0500)]
Cleanup branchtransfers
Remove unused sub and variables.
Convert to using GetBranchesLoop instead of local code.
Use elsif where appropriate.
Added fallback values and enabled warnings.
Joe Atzberger [Fri, 22 May 2009 19:35:35 +0000 (14:35 -0500)]
Cleanup transferstoreceive.pl and .tmpl
Removed unused variables. Replaced EXPR.
Inserted hidden span to correct tablesorter behavior on title field. Without this patch
because of the link href in the cell, the sort would end up being effectively on
biblionumber, not title.
This patch modify the database to have a grace period which can be set. And is used to create automatically new waited issues with a
cronjob(which is in this patch), and set old issues to "late" status.
Galen Charlton [Wed, 20 May 2009 16:35:55 +0000 (11:35 -0500)]
bug 3222: moved messaging preference editing
The display and editing of messaging preferences
for a patron have been moved as follows:
* the prefs for a patron are now displayed on the
patron details tab, not the messaging tab.
* the prefs are now modified by editing the patron
record, not on the messaging tab.
The messaging tab now contains only the list of
messages that have been or will be sent to the patron.
When creating a new patron record, changing the patron
category via the category dropdown now also changes
the default messaging preferences for that patron. If
you start editing a new patron, change one of the messaging
preferences, then change the patron category, the form will
ask you if you want to keep the preferences or get
the defaults belonging to the new patron category.
Note that when you edit an existing patron record, changing
the patron category will *not* cause the messaging preferences
to be automatically changed.
Programmer's note: this commit introduces a new web service,
members/default_messagingprefs.pl, that uses Jesse Weaver's
C4::Service module.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:54 +0000 (11:35 -0500)]
bug 3222: set messaging preferences during patron import
If the EnhancedMessagingPreferences option is ON, when
creating a new patron record via the patron import, set
the default messaging preferences to the applicable values
the default preferences for the patron category.
Messaging preferences are currently changed only when
*adding* a patron record via the import; if the import
updates an existing record, the patron's existing
preferences are not changed.
API changes:
SetMessagingPreferencesFromDefaults() is a new function
in C4::Members::Messaging to unconditionally replace
the current messaging preferences of a patron with the
default preferences from a specified patron category.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:53 +0000 (11:35 -0500)]
bug 3222: messaging preferences for patron categories
Add the ability to set the default circulation messages preferences
for a patron category. When the EnhancedMessagingPreferences
syspref is ON, the administrator will be able to define
default patron messaging preferences for a patron category. When
a new patron record is created (either manually or via a patron
import), the new patron's preferences will be copied from the default
for that patron's category.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:52 +0000 (11:35 -0500)]
bug 3222: new module to handle messaging preferences form
Define and use a new module, C4::Form::MessagingPreferences,
to handle displaying and processing the messaging preferences
form. This change reduces code duplication between OPAC
and staff.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:51 +0000 (11:35 -0500)]
bug 3222: changes to messaging preferences form
Moved the messaging preferences form to a new
include, messaging-preference-form.inc, so that
it can be used to set messaging prefs both for a
patron and for a patron category.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:50 +0000 (11:35 -0500)]
bug 3222: C4::Members::Messaging changes
Updated GetMessagingPreferences() and SetMessagingPreferences()
in this module to allow a categorycode to be passed
instead of a borrowernumber, permitting default preferences
for a patron category to be stored.
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Galen Charlton [Wed, 20 May 2009 16:35:49 +0000 (11:35 -0500)]
bug 3222: database changes for messaging preferences (DB rev 033)
This patch modifies the database for the messaging
preferences enhancement <http://wiki.koha.org/doku.php?id=en:development:rfcs3.2:rfc32_defaultmessagingsettings>
as follows:
* adds a categorycode column to borrower_message_preferences
This allows a set of messaging preferences to be linked
to a patron category
* allow the borrowernumber column to be null
This allows a messaging preference set to be linked
*only* to a patron category. If MySQL had check
constraints, I would add one so that exactly
one of borrowernumber and categorycode in a row in
borrower_message_preferences could be NULL.
* add a FK constraint from borrower_message_preferences.categorycode
to categories; if you delete a patron category, any default preferences
associated with it will be automatically deleted.
The messaging preference enhancement was sponsored by the Northeast
Kansas Library System (NEKLS).
Signed-off-by: Daniel Sweeney <daniel.sweeney@liblime.com> Signed-off-by: Galen Charlton <galen.charlton@liblime.com>
Joe Atzberger [Fri, 22 May 2009 01:37:46 +0000 (20:37 -0500)]
Bug 3239 - Content-Script-Type and Content-Style-Type
This adds headers to define the default script and style languages.
Please note that this output isn't 100% canonical from CGI yet, but
that is due to a bug in CGI:
http://bugs.koha.org/cgi-bin/bugzilla3/show_bug.cgi?id=3243
So either CGI will perfect it's output, or we can switch to using
HTTP::Headers. The latter may be desirable anyway, since then we
would not need a CGI $query argument at all.
Galen Charlton [Fri, 22 May 2009 12:41:22 +0000 (07:41 -0500)]
followup to previous patch - don't use TMPL_IF EXPR
Because of the way that HTML::Template::Pro evaluates
expressions, any variable referred to in a TMPL_IF EXPR
must be be present when the template is parsed, otherwise
you get Apache error log warnings like this:
non-initialized variable new_subfield
For a simple flag check, TMPL_IF NAME="new_subfield" is sufficient.
Galen Charlton [Fri, 22 May 2009 00:10:50 +0000 (19:10 -0500)]
bug 2001, 2432: improve unAPI implementation
Improves Koha's unAPI support as follows:
* The implementation no longer depends on there being
an accessible Zebra or SRW server. Instead, responses
are created by running the bib MARCXML through local
stylesheets.
* unAPI now works for all bibs, not just ones that have
an ISBN. The ID format is changed from koha:isbn:ISBN
to koha:biblionumber:BIBNUM.
* unAPI now correctly advertises the formats it supports.
* This implementation now passes validation testing at
http://validator.unapi.info/ .
* MODS3 support now works correctly. As a consequence, this
patch fixes bug 2432 (Zotero support when using the XSLT
OPAC stylesheets).
TODO: as additonal XSLT stylesheets are created to convert
UNIMARC bibs to additional formats, the stylesheet map
in opac/unapi should be updated.
koha [Wed, 20 May 2009 15:36:00 +0000 (15:36 +0000)]
Updated create_koc_db.pl to output SQlite2 files compatible with the Offline Circulation system, rather than the SQlite3 files that required post-processing.
[RM Note: patch by Kyle Hall <kyle.m.hall@gmail.com>]
Galen Charlton [Thu, 21 May 2009 20:03:57 +0000 (15:03 -0500)]
bug 2897: fix English sample notices
Same as Joe's prior 2897 patch, but applied to the English
sample_notices.sql - due to a Git merge and rename detection
oddity, his original submitted patch was applied to the French
sample_notices.sql. Since the two files are
currently identical, no problem in the end.
Joe Atzberger [Thu, 12 Feb 2009 20:49:33 +0000 (14:49 -0600)]
Bug 2897 - sample notices include bogus values
items.content is invalid for anything but overdue notices. It is
not processed by advance_notices.pl for DUE and PREDUE. Also, the
odd greeting "Dear firstname title" is standardized to match the
other messages' "Dear firstname surname".
Michael Hafen [Wed, 29 Oct 2008 19:48:04 +0000 (13:48 -0600)]
in Auth_with_ldap.pm try binding with user password or compare
This changes the checkpw code in Auth_with_ldap. Along with comparing
the user entered password against the directory attibute userPassword
you can try to bind with the users dn and password.
This is controlled by the option auth_by_bind, which, if set, causes
this code to try binding instead of comparing.
this patch fix the searchorder function, and add to the SQL query a "AND biblionumber" statement if a biblionumber is speficied.
Sometimes C4::Acquisitions::searchorder() find more than one result, so the user is looping to the same page to choose the great record, adding a contraint to biblionumber allows to be more strict.
Joe Atzberger [Wed, 20 May 2009 21:55:09 +0000 (16:55 -0500)]
Cleanup and enhance bookcount.pl and .tmpl
Eliminated bug with date handling outputting an English string.
Row striping added. Highlight for "my branch" row added.
GetBranchesLoop used instead of recreating data structure, so we get the
benefit of branches being sorted (by display name).
Joe Atzberger [Wed, 20 May 2009 19:39:03 +0000 (14:39 -0500)]
Add onlymine helper function.
This should allow scripts to use GetBranchesLoop without having to reproduce
the check for:
(1) IndependantBranches,
(2) User logged in,
(3) User Not superlibrarian, and
(4) User branch set.
Bug 3107. Creation of `permissions` table fails during the web-installation (ru-RU)
ERROR 1452 (23000) at line 3: Cannot add or update a child row: a foreign key constraint fails (`koha/permissions`,
CONSTRAINT `permissions_ibfk_1` FOREIGN KEY (`module_bit`) REFERENCES `userflags` (`bit`) ON DELETE CASCADE ON
UPDATE CASCADE)
Joe Atzberger [Tue, 19 May 2009 18:23:49 +0000 (13:23 -0500)]
Cleanup returns, consolidate some repeated logic.
Use one $userenv_branch instead of many calls to C4::Context->userenv->{'branch'}
for comparisons. Script is not warnings safe yet, but getting closer.
Galen Charlton [Tue, 19 May 2009 12:22:42 +0000 (07:22 -0500)]
bug 3236: remove disused scripts and a function
Removed opac/opac-dictionary.pl and catalogue/dictionary.pl,
which were not in use and not linked to from any active
template files. According to Henri, the functionality that
these scripts implemented hasn't been working since 2.2.
Also removed C4::Search::findseealso(), which was used
only by the two scripts.
Garry Collum [Sun, 17 May 2009 22:20:05 +0000 (18:20 -0400)]
Bug 1768: Calendar now retains the month on which the user was entering data.
If a user adds or edits a holiday, the calendar will now return to the month in which the user was working. Also after an add or an edit, if the user selects another location, the calendar remains in the same month for which the add or edit took place. The user sees a 'calendardate' parameter in the URL in the format that is chosen as the system preference. If an invalid date is entered in the url, the current date is used.
Galen Charlton [Fri, 15 May 2009 14:40:00 +0000 (09:40 -0500)]
bug 1448: improve subject classification browser
* turn on warnings
* fix problem where the top level of the classification
hiearchy wasn't displayed, instead pointing to
the link to the Wiki page with instructions on
how to set up the feature.
* fix XHTML validation errors
projects / koha.git / log