Owen Leonard [Thu, 3 Nov 2022 12:01:22 +0000 (12:01 +0000)]
Bug 32086: Consistent classes for primary buttons: Patrons
This patch makes changes the button markup in patron
module templates so that all submit buttons and any buttons that should
should be styled as primary buttons have the Bootstrap class "btn
btn-primary."
To test, apply the patch and view patron module pages to confirm
that everything looks correct. In most cases there are no visible
changes.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Emmi Takkinen [Thu, 3 Nov 2022 12:40:40 +0000 (14:40 +0200)]
Bug 31447: Add unit tests
To test prove t/db_dependent/Circulation.t
Sponsored-by: Koha-Suomi Oy Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Emmi Takkinen [Tue, 23 Aug 2022 10:48:39 +0000 (13:48 +0300)]
Bug 31447: Use holds pick up branch in "Please confirm checkout" message
When one tries to check out item which has hold in it,
"Please confirm checkout" message uses patrons home library
instead of holds pick up library. It would be more logical
to use latter here.
To test:
1. Find record with holds.
2. For first priority hold, change it's pick up library to differ from patrons homebranch if needed.
3. Check out records item for a different patron.
=> Note that notice reads: "Item ... has been on hold for ... at [patrons homebranch] since ...".
4. Apply this patch.
5. Repeat steps 2 and 3.
=> Notice should now read: "Item ... has been on hold for ... at [holds pick up branch] since ...".
Sponsored-by: Koha-Suomi Oy Signed-off-by: Axelle Clarisse <axelle.clarisse@univ-amu.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Katrin Fischer [Sun, 13 Nov 2022 14:06:42 +0000 (14:06 +0000)]
Bug 20207: Don't show search options when no suggestions show
When you are not logged in and OPACViewOthersSuggestions is
deactivated, you don't see any suggestions.
When we see no suggestions, we should also not show the option
to serach in suggestions.
To test:
* as a logged in user and logged out, try various combinations of:
* OPACViewOthersSuggestions
* AnonSuggestions
* Verify display matches expectations (new button, shown suggestions,
search input)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Mark Hofstetter [Fri, 11 Nov 2022 12:38:08 +0000 (13:38 +0100)]
Bug 20207: Don't show anyones's suggestions when OPACViewOthersSuggestions is deactivated
When you enable AnonSuggestions and ALLOW patrons that aren't logged
in to make purchase suggestions, once a suggestion has successfully
been submitted, anonymous purchase suggestions will show on OPAC even
when system preference OPACViewOthersSuggestions, is set to Don't show.
The suggestions will show on opac-suggestions.pl. However, if you search
for the title you suggested, you will get a message saying
"You are not authorized to see pending purchase suggestions."
This patch fixes the error, ie if OPACViewOthersSuggestions is set to
false not other suggestions are shown (if you are not logged in and AnonSuggestions)
OR ONLY your own suggestions if you are logged in
To test:
1) activate AnonSuggestions
2) create an anon suggestion
3) create a suggestion with a logged in user
4) toggle OPACViewOthersSuggestions Show/Don't show
5) all suggestions are shown cgi-bin/koha/opac-suggestions.pl in either case
6) apply patch
7) OPACViewOthersSuggestions is now respected ie suggestions from other users are only shown if activated
8) Please sign off
Sponsored-by: Library of the Natural History Museum Vienna Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Katrin Fischer [Sun, 13 Nov 2022 13:31:44 +0000 (13:31 +0000)]
Bug 32185: Fix template typo in opac-reserve.pl
This removes the %] showing for not for loan items disappear.
To test:
* Create a record with multiple items, mark one 'not for loan'
* Place an item level request on this record in the OPAC
* Make sure you 'Show nonholdable items'
* Verify the %] shows in the column with the not for loan status
* Apply patch
* Verify display is now improved
Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 4 Nov 2022 12:03:53 +0000 (13:03 +0100)]
Bug 31261: Introduce flatpickr-futureinclusive
That let us use future + today, and it's working perfectly for our use
case :)
Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Sun, 31 Jul 2022 06:29:41 +0000 (08:29 +0200)]
Bug 31261: Disable dates in the past for curbside pickups
When creating a new pickup the dates in the past won't display any
available slots. It would be better to disable them in the date picker.
Test plan:
Setup curbside pickups for your library (see bug 30650 test plan if
needed)
Create a new pickup (staff and OPAC) and confirm that the date picker widget
has the dates in the past disabled.
QA note: More work would be needed to sync calendar.inc code between
OPAC and staff. Also note that the "clear date" code wasn't needed
(please confirm).
Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 11 Nov 2022 11:17:28 +0000 (12:17 +0100)]
Bug 31782: Remove js/autocomplete/patrons.js
On 30578 we replace circ/ysearch.pl with a call to the /api/v1/patrons
route. A new patron_autocomplete JS function has been written
(js/patron-autocomplete.js) for that purpose.
However 3 occurrences were using an existing patron_autocomplete
function, and 30578 didn't take care of adjusting correctly the call to
the REST API route.
On this patchset I am suggesting to copy/paste the JS functions defined
in js/autocomplete/patrons.js, because we are very close of the 22.11
release. But ideally we should improve js/patron-autocomplete.js to add
a new 'on-select-add-to' option that will take care of add/remove/hide
behaviour. IMO that must be done on a separate bug, and after 22.11 is
released (to not need to retest the other occurrences of the patron
autocomplete)
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 11 Nov 2022 11:16:35 +0000 (12:16 +0100)]
Bug 31782: Fix autocomplete when duplicating orders
Test plan:
Add a new order to a basket from an existing order
Search for the order to duplicate using the "Basket created by" field
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 11 Nov 2022 11:13:21 +0000 (12:13 +0100)]
Bug 31782: Fix patron autocomplete on order search
Test plan:
Search for order using the "Basket created by" field
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 11 Nov 2022 11:10:28 +0000 (12:10 +0100)]
Bug 31782: Fix patron autocomplete on patron list
Test plan:
Add new patrons to a patron list
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Martin Renvoize [Fri, 11 Nov 2022 14:30:18 +0000 (14:30 +0000)]
Bug 32179: Add page-sections as appropraite to the ERM module
We missed the page-section addition when ERM was updated for the new UI
prior to push.
Test plan
1) Start a koha-testing-docker
2) Build the ERM module with 'kshell > yarn install > yarn build_js'
3) Enable the ERM module via the system preferences
4) Enable both 'EBSCO' and 'Local' as providers
4) Check the following pages
* ERM > Agreements
* ERM > Licenses
* ERM > eHoldings > Local > Packages
* ERM > eHoldings > Local > Titles
* ERM > eHoldings > Local > Titles > Add from a list
* ERM > eHoldings > EBSCO > Packages
* ERM > eHoldings > EBSCO > Titles
5) Apply this patch
6) Build the app again 'yarn build_js'
7) Confirm page-sections appear as expected on the pages mentioned in
step 4.
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 2 Nov 2022 12:18:31 +0000 (12:18 +0000)]
Bug 32072: Consistent classes for primary buttons: Cataloging
This patch makes changes the button markup in Cataloging templates
so that all submit buttons and any buttons that should should be styled
as primary buttons have the Bootstrap class "btn btn-primary."
To test, apply the patch and view pages in Cataloging to confirm
that everything looks correct. In most cases there are no visible
changes.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Marcel de Rooy [Wed, 9 Nov 2022 15:12:31 +0000 (15:12 +0000)]
Bug 32151: Resolve uninitialized warn in numeric ne in C4::Ris
We should not write:
if ($kwfield != undef) {
Test plan:
Pick record with UTF8 chars.
Download via cart or shelf in RIS format.
Check your logs.
Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 10 Nov 2022 19:04:11 +0000 (19:04 +0000)]
Bug 32158: Specify due date field is very long now
This patch adds a reasonable width to the "specify due date" date field
on the circulation page.
To test, apply the patch and rebuild the staff interface CSS.
Check out to a patron and click the "setting" icon on the "Enter item
barcode" field.
In the checkout setting panel, confirm that the date field isn't
unreasonably wide.
Signed-off-by: Barbara Johnson <barbara.johnson@swbell.net> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Thu, 10 Nov 2022 07:16:06 +0000 (08:16 +0100)]
Bug 32163: (bug 32030 follow-up) Fix koha_object[s]_class for ErmUserRole
Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Thu, 10 Nov 2022 06:36:19 +0000 (07:36 +0100)]
Bug 32161: (bug 32030 follow-up) Fix koha_object[s]_class for ErmEholdingsPackagesAgreement
Test plan:
run t/db_dependent/TestBuilder.t and confirm that the error related to
this module is gone. Another one may still fail however
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Pedro Amorim [Wed, 9 Nov 2022 17:55:20 +0000 (16:55 -0100)]
Bug 32154: Missing primary key on erm_user_roles table
The aforementioned TestBuilder should display "Koha::ERM::UserRole", not be empty.
This patch adds a primary key to the erm_user_roles table and fixes that.
Also includes atomicupdate file to update database schema as well as updates to
kohastructure.sql provided by Jonathan Druart.
Looked into the vue files but didn't find anywhere or a need to include the new
primary key in any of the requests as there is no request of users by role_user_id
being made.
Erm users are being created/updated as a relationship through licenceses/agreements.
Furthermore, when editing a role of an existing user, this new primary key is already
being supplied embeded in the license/agreement.
Test plan:
Add users to license and agreement
Run the cypress tests
Confirm that the change fix the test that was failing in TestBuilder.t
(another one may still fail however)
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Thu, 10 Nov 2022 07:06:28 +0000 (08:06 +0100)]
Bug 32162: Add primar key to erm_eholdings_packages_agreements
Test plan:
Confirm that this change fixes the related TestBuilder.t failure
Confirm that it does not break the eRM app, try to attach an agreement
to a package.
Signed-off-by: Pedro Amorim <pedro.amorim@ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Tue, 8 Nov 2022 06:16:04 +0000 (07:16 +0100)]
Bug 32130: Add a test to ensure vue files will be kept tidy
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 26 Oct 2022 18:29:23 +0000 (18:29 +0000)]
Bug 37159: Updated tab style
To test, apply the patch and rebuild the staff interface CSS
(https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client).
Test plan
1) Confirm the styling change for top level tabs on patron details or catalog
details pages.
2) Confirm the styling change is ok for a nested set of tabs (catalog
holds page is a good example).
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
https://bugs.koha-community.org/show_bug.cgi?id=31759
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 10 Nov 2022 14:40:41 +0000 (14:40 +0000)]
Bug 31819: Formatting of item form in acq when ordering is broken
I propose that we add CSS to the page to fix this since it's fairly
specific to the way this page is broken.
To test, apply the patch and view a basket in Acquisitions.
- Click "Add to basket" and choose "From a new (empty) record."
- Confirm that the item form layout looks correct.
- Perform the same test when adding to a basket from an existing record.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 10 Nov 2022 11:49:33 +0000 (11:49 +0000)]
Bug 32145: Fix style of buttons with class .btn-danger
This patch adds style to the staff client's global SCSS which adds
correct styling to buttons classed with .btn-danger.
This isn't the correct way to fix this, but it's the fast way.
Rebuilding Bootstrap with custom colors is the correct way, but
Bootstrap 3.x doesn't use SCSS. I consider this is a FIXME for an
upgrade of Bootstrap in the staff interface.
To test, apply the patch and rebuild the staff interface CSS. Test
instances where the .btn-danger class is used. Two examples:
Holds:
- Locate a bibliographic records with holds and view the holds.
- Click the "trash" icon to delete one of the holds.
- In the confirmation modal, check that the "Confirm cancellation"
button looks correct in its default, hover, and active ("clicked")
state.
Cataloging:
- Open a new blank record in the basic MARC editor.
- Click "Save" without filling any mandatory fields.
- You should see a warning about the empty fields.
- Scroll down until the warning is offscreen. An "Errors" button should
appear in the toolbar.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 2 Nov 2022 12:37:16 +0000 (12:37 +0000)]
Bug 32073: Consistent classes for primary buttons: Circulation
This patch makes changes the button markup in Circulation templates --
including offline circulation -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."
To test, apply the patch and view pages in Circulation to confirm
that everything looks correct. In most cases there are no visible
changes.
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Kyle Hall [Mon, 17 Oct 2022 13:35:13 +0000 (09:35 -0400)]
Bug 24606: (QA follow-up) Set existing sharing setting when updating existing template
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Kyle Hall [Thu, 6 Oct 2022 14:08:45 +0000 (10:08 -0400)]
Bug 24606: Add item template editor permission
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Kyle Hall [Thu, 29 Sep 2022 13:06:28 +0000 (09:06 -0400)]
Bug 24606: Implement item templates
This patch set implements item editor templates for community Koha.
Test Plan:
1) Apply this patch set
2) Run updatedatabase.pl
3) Restart all the things!
4) prove t/db_dependent/Koha/Item/Template*
5) As a non superlibrarian, enter the item editor
6) Set some item fields, save as a new template using the buttom and
form below the editor.
7) Test loading a template without remembering for the session
8) Test loading a template while remembering for the session
9) Test deleting a template
10) Test updating a template
11) Create one or more shared templates
12) Log in as another non superlibrarian without the new permission manage_item_editor_templates,
verify you cannot edit/delete templates shared to you
13) Enable the new permission manage_item_editor_templates,
verify you can now edit and delete templates shared to you
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Kyle Hall [Thu, 29 Sep 2022 13:05:07 +0000 (09:05 -0400)]
Bug 24606: Add Koha Object(s) with unit tests
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Kyle Hall [Thu, 29 Sep 2022 13:03:55 +0000 (09:03 -0400)]
Bug 24606: Update database, add new schema file
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nick Clemens [Thu, 3 Nov 2022 13:09:01 +0000 (13:09 +0000)]
Bug 8948: (follow-up) Correct OPAC link
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nick Clemens [Thu, 3 Nov 2022 12:05:59 +0000 (12:05 +0000)]
Bug 8948: Changes for OPAC
Test with same record, confirm OPAC view is as expected
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Nick Clemens [Fri, 28 Oct 2022 16:38:22 +0000 (16:38 +0000)]
Bug 8948: Display MARC 787 relationship field
This field is defined similar to 775, as a related work:
https://www.loc.gov/marc/bibliographic/bd787.html
This patch adds a display of this field, linking to the referenced record as the 775 does
It also tests for 580 field, and displays the text there if present, using the 787 a and t subfields otherwise
To test:
1 - Edit the default framework to make 787atw and 580a visible in editor
2 - Add a 787 to a record:
$tThe ideas behind the chess openings
$aFine, Reuben<
$w2470231
3 - Confirm there is no display
4 - Apply patch / restart all
5 - 'Other related works' now shows
6 - Link should be using title of record
7 - Set system preference UseControlNumber to Use
8 - Reload details, link should now use control number
9 - Add a 580 to the record:
$a This is a friendly work to this one
10 - Confirm the text of the link now displays before the link
11 - Add a second 580, confirm it displays as well
- there is no seperator as each should end with a period or other punctuation according to MARC
- there is a dpan with a class surrounding each so styling can be added as desired
12 - Add a second 787
- confirm seperator present and wrapped in a span with a class
- confirm each 787 is shown with a span/class for styling
Signed-off-by: Andrew Fuerste-Henry <andrewfh@dubcolib.org> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 3 Nov 2022 14:25:45 +0000 (14:25 +0000)]
Bug 32091: Consistent classes for primary buttons: Reports
This patch makes changes the button markup in reports templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."
To test, apply the patch and view reports pages to confirm that
everything looks correct. In most cases there are no visible changes.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 3 Nov 2022 14:57:32 +0000 (14:57 +0000)]
Bug 32097: Consistent classes for primary buttons: Lists
This patch makes changes the button markup in lists templates so that
all submit buttons and any buttons that should should be styled as
primary buttons have the Bootstrap class "btn btn-primary."
To test, apply the patch and view lists pages to confirm that everything
looks correct. In most cases there are no visible changes.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 3 Nov 2022 18:20:39 +0000 (18:20 +0000)]
Bug 32102: Improve specificity of batch record modification breadcrumbs
This patch makes a minor change to the batch record modification
template so that there is a link back to the initial view after you have
submitted a batch for modification.
To test, apply the patch and go to Cataloging -> Batch record
modification.
- Initially the breadcrumbs menu should show Home -> Cataloging -> Batch
record modification
- Submit a batch of bibliographic or authority records for modification
- The breadcrumbs should now read Home -> Cataloging -> Batch record
modification -> Results
- The same menu options should show after you confirm the operation
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Fri, 4 Nov 2022 17:24:48 +0000 (17:24 +0000)]
Bug 32043: Circulation alerts can overlap other elements on smaller screens
This patch makes a minor change to CSS controlling the appearance of the
dialog which appears on the checkout page when a confirmation is
required.
To test, apply the patch and rebuild the staff interface CSS.
Open a patron account for checkout, and submit the barcode of an item
which will require confirmation before the operation can be completed.
For example:
- Item on hold for another patron
- Item waiting for another patron
- Item is checked out to another patron.
The confirmation dialog should have a comfortable margin between it and
the checkout form.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Jonathan Druart [Fri, 4 Nov 2022 14:00:54 +0000 (15:00 +0100)]
Bug 31262: Curbside pickup - Remove day without slots
We disable dates from the date picker that do not have slots defined in
the configuration.
Note that dates that have slots configured but none are available will
still be displayed. To implement that we would need to calculate the
availability for all the dates displayed on the widget (1 month) and
that will (certainly) slow down considerabily the UI.
Test plan:
Configure curbside pickup for a given library. Define slots for several
days of the week (not all).
Schedule a pickup and confirm that only the days with slots defined are
available in the date picker widget
Sponsored-by: Association KohaLa - https://koha-fr.org/ Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 2 Nov 2022 12:02:43 +0000 (12:02 +0000)]
Bug 32071: Consistent classes for primary buttons: Catalog
This patch makes changes the button markup in Catalog
templates -- including the Cart -- so that all submit buttons and any
buttons that should should be styled as primary buttons have the
Bootstrap class "btn btn-primary."
Edit: This revised patch changes the button styles on the search history
page to make them more consistent with buttons in similar interfaces
(see catalog search results).
The patch also adds Bootstrap size classes to the item detail page and
removes some global CSS which targeted buttons on that page.
To test, apply the patch and view pages the catalog to confirm
that everything looks correct. In most cases there are no visible
changes.
- Advanced search: The main search button at the top
- Search results: The "Search within results" submit button
- Bibliographic detail page: This change is to a hidden button. This
section can be removed in a separate bug.
- Bibliographic detail page -> Items: Various "Update" and "Set status"
buttons. Note that the alignment of buttons has not changed in the
redesign.
- Item search: The main search button at the top
- Search history (from the logged-in user's menu in the top right):
"Delete" buttons in each section
- Catalog -- Current and previous sessions
- Authority -- Current and previous sessions
- In the Cart popup window, click "Send." In the resulting popup, the
"Send button.
- The template basket/downloadcart.tt has been modified but I think the
template might be unused.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Thu, 27 Oct 2022 16:48:29 +0000 (16:48 +0000)]
Bug 32101: Add padding to floating toolbars
This patch makes a slight change to the CSS controling the appearance of
floating toolbars. In some cases the lack of padding around the toolbar
elements made it look awkward.
To test, apply the patch and rebuild the staff interface CSS.
View various pages to confirm that the toolbar looks correct when you
scroll down and the toolbar "sticks" to the top of the browser viewport.
For example:
- Patrons -> Search results
- Patrons -> Add/edit patron
- Catalog -> Advanced search form
- Administration -> Preferences
- Authorities -> Add/edit authority
- Cataloging -> Add/edit MARC record
- Catalog -> Item search form
Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 14:09:17 +0000 (14:09 +0000)]
Bug 32148: Buttons must inherit Bootstrap size classes
This patch removes global font and padding settings which were
overriding the Bootstrap classes we use to change the size of Bootstrap
buttons. The font and padding settings are moved to the CSS which covers
button which are not styled as Bootstrap buttons.
To test, apply the patch and view pages where buttons are styled with
different Bootstrap size classes:
- Circulation -> Check out:
- The "Check out" button, the "Show checkouts" button, Renew buttons
in the footer.
- Patrons -> Patron details -> Edit buttons in each section.
- Patrons home -> Buttons in sidebar filter
- Catalog -> Bibliographic details -> Item details
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 18:19:51 +0000 (18:19 +0000)]
Bug 31928: Add page-section to callnumber browser value builder (cat)
This patch adds a page-section div around the search results shown by
the call number browser plugin in Cataloging.
The patch also restructures the search form so that the layout is
correct.
To test you must have an item subfield linked to the call number browser
plugin:
- Go to MARC frameworks -> Default MARC framework -> MARC structure.
- Locate the 952 tag and click Actions -> Edit subfields.
- Open the "o" tab and in the last section, "Other options," choose
"cn_browser.pl" for the plugin field.
Open an item record for editing:
- Go to Cataloging and search for a bibliographic record.
- Click Actions -> Add/Edit items for one of the results.
- In the item edit form, the "o - Full call number" field should have a
"..." link at the end.
- Clicking it should trigger a popup window.
- The search form at the top should be laid out correctly.
- Perform a search which will return results.
- The table of results should be contained within a white box.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 15:43:50 +0000 (15:43 +0000)]
Bug 32146: Add page-section to course reserves
This patch adds a "page-section" wrapping div to two Course Reserves
templates.
Note: This patch contains indentation changes.
To test, apply the patch and go to Course Reserves.
- The table of course reserves should appear in a white section.
- View the details of a course: There should be a white section for the
list of details at the top and another for the table of reserves.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 16:24:06 +0000 (16:24 +0000)]
Bug 31828: Add page-section to list of open invoices on receive shipment page (acq)
This patch adds a "page-section" class to the div wrapping the table
of shipments on the "Receive shipment" page in Acquisitions.
This patch also modifies the markup around additional fields so that an
empty fieldset is not displayed when there are no additional fields to
display.
To test, apply the patch and go to Acquisitions.
- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- On the receive page, there should be a section listing shipments and a
section headed "Receive a new shipment."
- If you have additional fields defined (in Administration -> Additional
fields -> Invoices) there should be a third section showing those
fields.
- With no additional fields defined you should not see an empty
fieldset.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 17:28:13 +0000 (17:28 +0000)]
Bug 31827: Add page-section to list to log viewer
This patch adds a "page-section" container div around the log viewer
output.
To test, apply the patch and go to Tools -> Logs.
- Perform a log search which will return results.
- The table of results should appear in a white box.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 17:12:02 +0000 (17:12 +0000)]
Bug 31826: Add page-section to item form on order receive page (acq)
This patch adds a "page-section" class to the container div around the
items table on the order receive page in acquisitions.
To test, apply the patch and go to Acquisitions.
- Locate a vendor and few its details.
- Click "Receive shipments."
- Fill out the "Receive shipment" form if you have no existing
shipments. Otherwise click on the invoice number link to get to the
"Receive orders" page.
- In the table of pending orders, click a "Receive" link.
- On the "Receive items" page there should be three sections: Catalog
details, Acquisitions details, and Items.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 16:42:54 +0000 (16:42 +0000)]
Bug 31824: Add page-section to list of pending/received orders (acq)
This patch adds a "page-section" class to the divs wrapping two
sections on the "Receive orders" page in Acquisitions.
To test, apply the patch and go to Acquisitions.
- Locate a vendor and view its details.
- In the toolbar, click "Receive shipments."
- If you have existing shipments listed in the first section, click the
invoice number link.
- If not, fill out the "receive a new shipment" form and submit it.
- On the "Receive orders" page there should be two sections: "Pending
orders" and "Already received."
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Owen Leonard [Wed, 9 Nov 2022 16:14:39 +0000 (16:14 +0000)]
Bug 31823: Add page-section to uncertain prices page (acq)
This patch adds a "page-section" wrapping div to the uncertain prices
page in Acquisitions
Note: This patch contains indentation changes.
To test, apply the patch and go to Acquisitions.
- Locate a vendor and view its details
- In the left-hand sidebar, click "Uncertain prices."
- The page should have two sections: Details about the vendor, and a
list of orders with uncertain prices.
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Hooks added:
after_recall_action with new action add
How to test:
Run tests in t/db_dependent/Koha/Plugins/Recall_hooks.t
Sponsored by: Gothenburg University Library
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
[EDIT} Adding get_from_storage ;) For current consistency.
See further bug 32107. Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Bug 30250: (follow-up) Clarify syspref wording around importing
Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Aleisha Amohia [Tue, 22 Mar 2022 21:26:35 +0000 (21:26 +0000)]
Bug 30250: Use ApplyFrameworkDefaults when importing a record
This patch adds the case of importing a record to the
ApplyFrameworkDefaults options.
To test:
1. Update database
2. Confirm the ApplyFrameworkDefaults system preference now has the
'when importing a record via z39.50' option. Do not select it.
3. Go to Cataloguing. Import a record from z39.50, or replace an
existing record.
4. Confirm framework defaults are not applied.
5. Go back to the system preference and check the 'when importing a
record via z39.50' option.
6. Repeat step 3. This time framework defaults should be applied. Only
fields that are empty in the imported record will be replaced by
framework defaults.
7. Repeat for authorities.
Sponsored-by: Catalyst IT Signed-off-by: David Nind <david@davidnind.com> Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
projects / koha.git / log