]> git.koha-community.org Git - koha.git/commit
Bug 27593: Consistent behavior for club holds route
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 2 Feb 2021 14:22:50 +0000 (11:22 -0300)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 23 Feb 2021 12:16:07 +0000 (13:16 +0100)
commit2387ac731c03ecfa6cd20e7e71037bbd3c3ac046
tree858246b00f76de46facaa27088082ae93e5904e4
parent024a32ca807bb69b3d46136421dce871ba0bddbf
Bug 27593: Consistent behavior for club holds route

This patch:
- Fixes a malformed response when biblio_id is invalid
- Fixes the return status (400 => 404) when biblio_id is invalid
- Adapts the error strings to be consistent with the Cities.pm file

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail
3. Apply this patch
4. Repeat 2
=> SUCCESS: Tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/REST/V1/Clubs/Holds.pm