Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac
authorTomas Cohen Arazi <tomascohen@theke.io>
Fri, 29 Jan 2021 19:43:06 +0000 (16:43 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Fri, 5 Feb 2021 15:36:28 +0000 (16:36 +0100)
commit606f47b2e91dcc51b1348356d672e95f8943ab8a
tree40c901a88d7fcce9ea9782be504dbe2f921ee91d
parentd767dc54a60e233afa9d295798eacc8cbc28a5f1
Bug 27580: Handle NULL values correctly in Koha::Items->filter_by_visible_in_opac

This patch fixes the internally used query so it doesn't consider NULL
values as IN the set.

To test:
1. Apply the regression tests patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/Koha/Items.t
=> FAIL: Tests fail :-/
3. Apply this patch
4. Repeat 2
=> SUCCESS: tests pass!
5. Sign off :-D

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit b60ff6452ef2212a02f16ddc5c46edeb3d83a5e3)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Koha/Items.pm