]> git.koha-community.org Git - koha.git/commit
Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority
authorMarcel de Rooy <m.de.rooy@rijksmuseum.nl>
Mon, 26 Jun 2017 11:41:56 +0000 (13:41 +0200)
committerJonathan Druart <jonathan.druart@bugs.koha-community.org>
Tue, 12 Sep 2017 15:07:47 +0000 (12:07 -0300)
commitdb35492c795540d6c3b10f7cba18698aeb84a816
tree5b6be9cf1c9a18c0cc36cf2f262af02dcd1e371e
parent3e631f418a3fafa485b650f0975ee0d06e366884
Bug 17380: Do not use GuessAuthTypeCode in MetadataRecord::Authority

If we got an authtypecode from the database and this value is not NULL
since the table column does not allow it, there is no need to call
GuessAuthTypeCode for empty string (read: Default framework) in the
sub get_from_authid.

Furthermore, we remove three Koha::MetadataRecord::Authority->new calls.
They are useless, since we do not pass a record. It just generates:
  No record passed at authorities/merge.pl line 96.
  Can't bless non-reference value at Koha/MetadataRecord/Authority.pm line 66.
Instead we throw an ObjectNotFound exception.

Test plan:
[1] Run t/db_dependent/Koha_Authority.t
[2] Interface will be tested in the following patches.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Koha/MetadataRecord/Authority.pm
authorities/merge.pl