]> git.koha-community.org Git - koha.git/commit
Bug 27593: Regression tests
authorTomas Cohen Arazi <tomascohen@theke.io>
Tue, 2 Feb 2021 14:18:27 +0000 (11:18 -0300)
committerFridolin Somers <fridolin.somers@biblibre.com>
Thu, 25 Feb 2021 09:52:37 +0000 (10:52 +0100)
commite950abb5352aa29d91de47a40f67067d237836fb
treea97df91cdc853271299b831022e109cb2c5db025
parentf1c01793be031ada3de20cc9652c1c31e2f5e94d
Bug 27593: Regression tests

This patch introduces tests for the behaviour change (400 => 404) and
also adds tests for untested (error) behaviours. Notably, the 'Biblio
not found' problematic return value couldn't be triggered, because the
OpenAPI plugin returns a 500 because the response was malformed
(expected { error => 'message' } and it was returning a string).

For the above reason, running the regression tests will show a 500...
instead of the expected 400.

I covered the rest of the codepaths that trigger errors to have full
coverage.

To test:
1. Apply this patch
2. Run:
   $ kshell
  k$ prove t/db_dependent/api/v1/clubs_holds.t
=> FAIL: Tests fail loudly

Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 024a32ca807bb69b3d46136421dce871ba0bddbf)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
t/db_dependent/api/v1/clubs_holds.t