From 15d6ecc82281b02b2d47b970628e1f41402295b9 Mon Sep 17 00:00:00 2001 From: arensb Date: Wed, 16 Oct 2002 12:42:29 +0000 Subject: [PATCH] Added some FIXME comments. --- C4/Biblio.pm | 14 ++++++++++++-- acqui.simple/bulkmarcimport.pl | 8 +++++++- .../default/en/catalogue/detail-opac.tmpl | 1 + .../intranet-tmpl/default/en/catalogue/detail.tmpl | 9 +++++++++ .../default/en/marcimport/marcimportdetail.tmpl | 1 + koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl | 1 + .../opac-tmpl/default/en/opac-moredetail.tmpl | 2 +- search.pl | 4 ++-- 8 files changed, 34 insertions(+), 6 deletions(-) diff --git a/C4/Biblio.pm b/C4/Biblio.pm index bb1f1f9f5f..7003e242b5 100644 --- a/C4/Biblio.pm +++ b/C4/Biblio.pm @@ -1,6 +1,9 @@ package C4::Biblio; # $Id$ # $Log$ +# Revision 1.23 2002/10/16 12:43:08 arensb +# Added some FIXME comments. +# # Revision 1.22 2002/10/15 13:39:17 tipaul # removing Acquisition.pm # deleting unused code in biblio.pm, rewriting POD and answering most FIXME comments @@ -1606,7 +1609,9 @@ fields from the biblio, biblioitems, aqorders, and aqorderbreakdown tables of the Koha database. =cut - +#' +# FIXME - This is effectively identical to &C4::Catalogue::getorder. +# Pick one and stick with it. sub getorder{ my ($bi,$bib)=@_; my $dbh = C4::Context->dbh; @@ -1615,6 +1620,8 @@ sub getorder{ where biblionumber=? and biblioitemnumber=?"; my $sth=$dbh->prepare($query); $sth->execute($bib,$bi); + # FIXME - Use fetchrow_array(), since we're only interested in the one + # value. my $ordnum=$sth->fetchrow_hashref; $sth->finish; my $order=getsingleorder($ordnum->{'ordernumber'}); @@ -1633,7 +1640,10 @@ C<$order> are fields from the biblio, biblioitems, aqorders, and aqorderbreakdown tables of the Koha database. =cut - +#' +# FIXME - This is effectively identical to +# &C4::Catalogue::getsingleorder. +# Pick one and stick with it. sub getsingleorder { my ($ordnum)=@_; my $dbh = C4::Context->dbh; diff --git a/acqui.simple/bulkmarcimport.pl b/acqui.simple/bulkmarcimport.pl index 27966da427..856b285b43 100755 --- a/acqui.simple/bulkmarcimport.pl +++ b/acqui.simple/bulkmarcimport.pl @@ -453,7 +453,9 @@ RECORD: my $q_dewey=$dbh->quote($dewey); $cleanauthor=$author; $cleanauthor=~s/[^A-Za-z]//g; - $subclass=uc(substr($cleanauthor,0,3)); + $subclass=ucz(substr($cleanauthor,0,3)); + # FIXME - WTF is the author being converted + # to upper case? my $q_subclass=$dbh->quote($subclass); my $q_publicationyear=$dbh->quote($publicationyear); my $q_publishercode=$dbh->quote($publishercode); # FIXME - $publishercode undefined @@ -473,6 +475,8 @@ RECORD: foreach $subjectheading (@subjects) { # convert to upper case $subjectheading=uc($subjectheading); + # FIXME - WTF is the subject being + # converted to upper case? # quote value my $q_subjectheading=$dbh->quote($subjectheading); $sth=$dbh->prepare("insert into bibliosubject (biblionumber,subject) @@ -487,6 +491,8 @@ RECORD: $additionalauthor=~s/\010//g; # convert to upper case $additionalauthor=uc($additionalauthor); + # FIXME - WTF is the author being converted + # to upper case? # quote value my $q_additionalauthor=$dbh->quote($additionalauthor); $sth=$dbh->prepare("insert into additionalauthors (biblionumber,author) values ($biblionumber, $q_additionalauthor)"); diff --git a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl index ae5e065498..f47ca05a57 100644 --- a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl +++ b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail-opac.tmpl @@ -10,6 +10,7 @@ ()

+ diff --git a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl index 63d6409340..19091e41de 100644 --- a/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl +++ b/koha-tmpl/intranet-tmpl/default/en/catalogue/detail.tmpl @@ -20,6 +20,7 @@ src="/images/requests.gif" align="right" border="0"> ()

+

@@ -60,6 +61,14 @@ NAME="author" ESCAPE=URL>>
+ +

diff --git a/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl b/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl index 22ba4e66f2..f8147668df 100644 --- a/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl +++ b/koha-tmpl/intranet-tmpl/default/en/marcimport/marcimportdetail.tmpl @@ -3,6 +3,7 @@ ()

+

diff --git a/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl b/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl index 35397c8831..4daf839f30 100644 --- a/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl +++ b/koha-tmpl/opac-tmpl/default/en/opac-detail.tmpl @@ -15,6 +15,7 @@ ()

+

diff --git a/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl b/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl index 3b9445d229..50ae2bf096 100644 --- a/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl +++ b/koha-tmpl/opac-tmpl/default/en/opac-moredetail.tmpl @@ -70,7 +70,7 @@ BORDER=0 src="/images/delete-mem.gif"> Home Branch:
Last seen:
Last borrowed:
-on issue bit +on issue bit Last Borrower 1:
Last Borrower 2:
Current Branch:
diff --git a/search.pl b/search.pl index 5d1a994a5a..3a41869862 100755 --- a/search.pl +++ b/search.pl @@ -28,12 +28,12 @@ use C4::Output; my $query=new CGI; my $type=$query->param('type'); -warn $type; +warn $type; # FIXME - What's this for? #(-e "opac") && ($type='opac'); my ($loggedinuser, $cookie, $sessionID) = checkauth($query, ($type eq 'opac') ? (1) : (0)); -warn $type; +warn $type; # FIXME - What's this for? my $startfrom=$query->param('startfrom'); ($startfrom) || ($startfrom=0); -- 2.39.5