From 26740cc57dde2d25290cf7632bd3b0751829b37f Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Thu, 27 Jul 2023 16:11:54 +0000 Subject: [PATCH] Bug 34436: Some breadcrumbs lack for translatability This patch modifies several templates which were updated recently so that breadcrumbs markup could be built using template wrappers. The patch wraps strings in in cases where it is necessary to make them translatable. To test, apply the patch and view the following pages to confirm that the breadcrumbs still show up correctly: - Administration -> MARC bibliographic framework - Add framework - Edit framework - Delete framework - Administration -> Share content with Mana KB - Administration -> Circulation and fine rules - Authorities -> - Add authority - Edit authority - Catalog -> Advanced search - Bibliographic detail page - Must have EasyAnalyticalRecords enabled. - Edit -> Link to host record - Patrons - Reports -> Average loan time - Serials -> Serials home Signed-off-by: Sam Lau Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 8933036742e5484639c2649042102117664ce9c7) Signed-off-by: Fridolin Somers (cherry picked from commit edaf57c73ee4048d577dc52d524d2c6b2f3b316d) Signed-off-by: Matt Blenkinsop --- .../prog/en/modules/admin/biblio_framework.tt | 8 ++++---- .../intranet-tmpl/prog/en/modules/admin/share_content.tt | 2 +- .../intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 2 +- .../prog/en/modules/authorities/authorities.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/catalogue/advsearch.tt | 2 +- .../intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt | 2 +- .../prog/en/modules/reports/issues_avg_stats.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/serials/serials-home.tt | 2 +- 9 files changed, 14 insertions(+), 14 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt index 0a709984e6..d451958431 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/biblio_framework.tt @@ -32,11 +32,11 @@ MARC frameworks › Administration › Koha [% END %] [% IF framework %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Modify framework text + Modify framework text [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Add framework + Add framework [% END %] [% END %] @@ -45,12 +45,12 @@ MARC frameworks › Administration › Koha MARC frameworks [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? + Delete framework for [% framework.frameworktext | html %] ([% framework.frameworkcode | html %])? [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - MARC frameworks + MARC frameworks [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt index cea35c77e2..a8fcbbdebe 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/share_content.tt @@ -18,7 +18,7 @@ Administration [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Share content with Mana KB + Share content with Mana KB [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 45a8b03792..f4d534d217 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -39,7 +39,7 @@ Administration [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Circulation and fine rules + Circulation and fine rules [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt index 7247813bb6..ea5f72701b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt @@ -263,12 +263,12 @@ [% IF ( authid ) %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Modify authority #[% authid | html %] ([% authtypetext | html %]) + Modify authority #[% authid | html %] ([% authtypetext | html %]) [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Adding authority [% authtypetext | html %] + Adding authority [% authtypetext | html %] [% END %] [% END %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt index 547f5b1794..df752818e1 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/advsearch.tt @@ -33,7 +33,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Advanced search + Advanced search [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt index 78927bc3f1..b74519b122 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/linkitem.tt @@ -15,7 +15,7 @@ Cataloging [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Link a host record to [% bibliotitle | html %] + Link a host record to [% bibliotitle | html %] [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt index 99b9eab095..250066fb7d 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/member.tt @@ -24,7 +24,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Patrons + Patrons [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt index d647883a0d..3b98f0be2c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_avg_stats.tt @@ -21,11 +21,11 @@ Average loan time [% END %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Results + Results [% END %] [% ELSE %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Average loan time + Average loan time [% END %] [% END %] [% END #/ WRAPPER breadcrumbs %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt index 9f5080736b..a9a7c7e061 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-home.tt @@ -16,7 +16,7 @@ [% WRAPPER 'sub-header.inc' %] [% WRAPPER breadcrumbs %] [% WRAPPER breadcrumb_item bc_active= 1 %] - Serials + Serials [% END %] [% END #/ WRAPPER breadcrumbs %] [% END #/ WRAPPER sub-header.inc %] -- 2.39.2