From 2d4226902d20bc0d3bcd696f34d56ac60ee2c5b6 Mon Sep 17 00:00:00 2001
From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
Date: Tue, 25 Oct 2016 09:16:56 +0200
Subject: [PATCH] Bug 17495: Fix 'method selected not covered by test' in
 reports/issues_stats.pl
MIME-Version: 1.0
Content-Type: text/plain; charset=utf8
Content-Transfer-Encoding: 8bit

If you access reports/issues_stats.pl, you will get
Template process failed: undef error - The method selected is not
covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121
http://localhost:8081/cgi-bin/koha/reports/reports-home.pl

Bug 15407 sent objects to the template and the selected method is not
defined.
The bug had been highlighted by bug 17425 which dies instead of hides the error.

Not that the "selected" code was not needed, the different elements of
the page never select a specific value.

Test plan:
Apply this patch and confirm that the error is no longuer displayed.

Reproduced. Followed test plan, works as expected.
Signed-off-by: Marc Véron <veron@veron.ch>

Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>

Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
---
 .../prog/en/modules/reports/issues_stats.tt        | 14 +++++++-------
 1 file changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
index aa227fabcc..d01e441ff4 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt
@@ -134,7 +134,7 @@
            <td><select name="Filter" id="borcat">
                <option value=""> </option>
                [% FOREACH categoryloo IN categoryloop %]
-                 [% IF ( categoryloo.selected ) %]<option value="[% categoryloo.categorycode %]" selected="selected">[% categoryloo.description %]</option>[% ELSE %]<option value="[% categoryloo.categorycode %]">[% categoryloo.description %]</option>[% END %]
+                 <option value="[% categoryloo.categorycode %]">[% categoryloo.description %]</option>
                [% END %]
                </select>
              </td> 
@@ -146,7 +146,7 @@
            <td><select name="Filter" id="itemtype">
                <option value=""> </option>
                [% FOREACH itemtypeloo IN itemtypeloop %]
-                 [% IF ( itemtypeloo.selected ) %]<option value="[% itemtypeloo.code %]" selected="selected">[% itemtypeloo.description %]</option>[% ELSE %]<option value="[% itemtypeloo.code %]">[% itemtypeloo.description %]</option>[% END %]
+                 <option value="[% itemtypeloo.code %]">[% itemtypeloo.description %]</option>
                [% END %]
                </select>
              </td> 
@@ -168,7 +168,7 @@
             <td><select name="Filter" id="ccode">
                 <option value=""> </option>
                 [% FOREACH ccodeloo IN ccodeloop %]
-					[% IF ( ccodeloo.selected ) %] <option value="[% ccodeloo.code %]" selected="selected">[% ccodeloo.description %]</option>[% ELSE %]<option value="[% ccodeloo.code %]">[% ccodeloo.description %]</option>[% END %]
+                    <option value="[% ccodeloo.code %]">[% ccodeloo.description %]</option>
                 [% END %]
                 </select>
             </td>
@@ -180,8 +180,8 @@
             <td><select name="Filter" id="location">
                 <option value=""> </option>
                 [% FOREACH locationloo IN locationloop %]
-					[% IF ( locationloo.selected ) %]<option value="[% locationloo.code %]" selected="selected">[% locationloo.description %]</option>[% ELSE %]<option value="[% locationloo.code %]">[% locationloo.description %]</option>[% END %]
-				[% END %]
+                    <option value="[% locationloo.code %]">[% locationloo.description %]</option>
+                [% END %]
                </select>
             </td> 
         </tr>
@@ -198,7 +198,7 @@
 			<td><select name="Filter" id="sort1">
                <option value=""> </option>
                [% FOREACH Bsort IN Bsort1 %]
-			   [% IF ( Bsort.selected ) %]<option value="[% Bsort.authorised_value %]" selected="selected">[% Bsort.lib %]</option>[% ELSE %]<option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>[% END %]
+                <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>
                [% END %]
                </select>
             </td> 
@@ -211,7 +211,7 @@
            	<td><select name="Filter" id="sort2">
                <option value=""> </option>
                [% FOREACH Bsort IN Bsort2 %]
-			   [% IF ( Bsort.selected ) %]<option value="[% Bsort.authorised_value %]" selected="selected">[% Bsort.lib %]</option>[% ELSE %]<option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>[% END %]
+                   <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>
                [% END %]
                </select>
             </td> 
-- 
2.39.5