From 58ba320d3a97e68c0634b1c1cc312fb12b9457df Mon Sep 17 00:00:00 2001 From: Katrin Fischer Date: Fri, 6 Jan 2023 22:33:43 +0000 Subject: [PATCH] Bug 31957: Improve translatability of text containing links on libraries admin page The libraries administration page has several links to system preferences that appear within sentences or with other text around it. To make translations easier, we need to make sure that those links don't break context. To test: * Activate IllModule (so we can see the ILL staff email setting) * Go to administration > libraries * Verify that the links for those settings show correctly * Reply-to * Return-Path * Ill staff email * MARC organization code * Apply patch * Verify links still work and show unchanged If you are familiar with the process, you can also make sure the strings now show up on po files as expected: https://wiki.koha-community.org/wiki/Translating_Koha#Updating_the_po_files_in_your_installation https://bugs.koha-community.org/show_bug.cgi?id=31954 Signed-off-by: Caroline Cyr La Rose Signed-off-by: Kyle M Hall Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 0e64ead240fd6df47a1a11e4e2439b1c9869da07) Signed-off-by: Pedro Amorim (cherry picked from commit 45c783398d6d89054d43aa1fbddb80b0b739a253) Signed-off-by: Lucas Gass --- .../intranet-tmpl/prog/en/modules/admin/branches.tt | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt index 606b9155be..0164562147 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/branches.tt @@ -175,7 +175,8 @@ Libraries › Administration › Koha
[% IF ( CAN_user_parameters_manage_sysprefs ) %] - Default: ILLDefaultStaffEmail system preference + [% SET pref_ILLDefaultStaffEmail_link = 'ILLDefaultStaffEmail' %] + Default: [% pref_ILLDefaultStaffEmail_link | $raw %] system preference [% ELSE %] Default: ILLDefaultStaffEmail system preference [% END %] @@ -187,7 +188,8 @@ Libraries › Administration › Koha
[% IF ( CAN_user_parameters_manage_sysprefs ) %] - Default: ReplyToDefault system preference + [% SET pref_ReplyToDefault_link = 'ReplyToDefault' %] + Default: [% pref_ReplyToDefault_link | $raw %] system preference [% ELSE %] Default: ReplyToDefault system preference [% END %] @@ -198,7 +200,8 @@ Libraries › Administration › Koha
[% IF ( CAN_user_parameters_manage_sysprefs ) %] - Default: ReturnpathDefault system preference + [% SET pref_ReturnpathDefault_link = 'ReturnpathDefault' %] + Default: [% pref_ReturnpathDefault_link | $raw %] system preference [% ELSE %] Default: ReturnpathDefault system preference [% END %] @@ -232,7 +235,8 @@ Libraries › Administration › Koha
[% IF ( CAN_user_parameters_manage_sysprefs ) %] - If not filled in defaults to system preference MARCOrgCode. + [% SET pref_MARCOrgCode_link = 'MARCOrgCode' %] + If not filled in defaults to system preference [% pref_MARCOrgCode_link | $raw %]. [% ELSE %] If not filled in defaults to system preference MARCOrgCode. [% END %] -- 2.39.5