From 7317b66b5a311f677107ba9333664bef3a55d317 Mon Sep 17 00:00:00 2001 From: Matt Blenkinsop Date: Wed, 24 Jan 2024 15:08:56 +0000 Subject: [PATCH] Bug 34647: Replace name attributes with ids This patch replaces name attributes on tags as this is now obsolete in HTML 5. The recommended practice is to substitute these for ids, as has been done in this patch Test plan: 1) Navigate to each page where the link has been amended 2) Check that the link still works as expected Signed-off-by: Owen Leonard Signed-off-by: Martin Renvoize Signed-off-by: Katrin Fischer (cherry picked from commit 8a07455e3beeb58ec934665d301bc76e4ef562a4) Signed-off-by: Fridolin Somers --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt | 2 +- koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt | 4 ++-- .../intranet-tmpl/prog/en/modules/reports/catalogue_out.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt | 2 +- koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +- 5 files changed, 6 insertions(+), 6 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt index 80b9ca786b..6c0643369c 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/booksellers.tt @@ -79,7 +79,7 @@ [% ELSE %]

[% END %] - + [% IF (supplier.name) %] [% supplier.name | html %] [% ELSE %] diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt index 05ac96ea3b..3d2ae0c80b 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt @@ -243,7 +243,7 @@ [% IF note.defined && note != '' %] - View note + View note [% ELSE %] [% END %] @@ -1497,7 +1497,7 @@ var current_column = $("#edit_row td:eq("+i+")"); if ( i == 3 ) { // specific processing for the Note column - var note = $(this).find("a[name='viewnote']").data("content"); + var note = $(this).find("a[id='viewnote']").data("content"); $(current_column).find("input[type='text']").val(note); } else if ( i == 9 ) { // specific processing for Hard due date diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt index 6194de328a..feaa023278 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/catalogue_out.tt @@ -81,7 +81,7 @@ [% IF ( mainloo.looptables ) %]
-

Summary

+

Summary

diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt index 8e616f02a7..8d2a88e3ae 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt @@ -94,7 +94,7 @@ [% IF ( news_item ) %] [% koha_new.title | html %] [% ELSE %] - [% koha_new.title | html %] + [% koha_new.title | html %] [% END %]
[% koha_new.content | $raw %]
diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt index 978c592b67..986448629b 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt +++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt @@ -978,7 +978,7 @@
    [% FOREACH pa IN pa_class.items %] [% FOREACH pa_value IN pa.values %] - [% IF loop.first %][% END %] + [% IF loop.first %][% END %] [% form_id = 'patron-attr-' _ Math.int( Math.rand(1000000) ) %]
  1. [% IF pa.type.mandatory && pa.type.opac_editable %] -- 2.39.5
Group