From 76aba15a35aa49895ea389cbad607135f9632eca Mon Sep 17 00:00:00 2001 From: Blou Date: Tue, 13 Oct 2015 16:12:49 -0400 Subject: [PATCH] Bug 15009 - Planning dropdown button in aqbudget can have empty line When displaying a budget, the Planning button in the admin toolbar displays Plan by months Plan by libraries Plan by item types Plan by The last one is empty, due to C4::Budgets::GetBudgetAuthCats returning an empty field if the budget has no sort defined. This prevents returning an array with empty element(s) TEST: 1) Admin -> Budgets 2) Select a budget a) you must have '' (empty) in your aqbudgets.sort1_authcat field. b) edit the budget (direct DB or interface) to get that. 3) Click on Planning dropdown, see the "Plan by " entry. 4) apply the patch, revalidate. Signed-off-by: Bernardo Gonzalez Kriegel No more empty option No errors Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall (cherry picked from commit b8076d8ec7236360274e1a4e861969c86bb679ea) Signed-off-by: Julian Maurice --- C4/Budgets.pm | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/C4/Budgets.pm b/C4/Budgets.pm index 79012ba329..7d15bae114 100644 --- a/C4/Budgets.pm +++ b/C4/Budgets.pm @@ -411,8 +411,8 @@ sub GetBudgetAuthCats { $sth->execute($budget_period_id); my %authcats; while (my ($sort1_authcat,$sort2_authcat) = $sth->fetchrow) { - $authcats{$sort1_authcat}=1; - $authcats{$sort2_authcat}=1; + $authcats{$sort1_authcat}=1 if $sort1_authcat; + $authcats{$sort2_authcat}=1 if $sort2_authcat; } my @auth_cats_loop; foreach (sort keys %authcats) { -- 2.39.5