From 8b61a24479ac84c4c51f4d9828b20725a1c0c7a0 Mon Sep 17 00:00:00 2001
From: Katrin Fischer <katrin.fischer.83@web.de>
Date: Wed, 16 Aug 2017 13:52:07 +0200
Subject: [PATCH] Bug 19108 - Follow-up - fieldmapping.tt and
 items_search_fields.tt

To test:
- Add a framework with script in the description
- Access the Keywords to MARC mapping page
- Add an item search field where both name and label are script
- Try to edit/delete the added mapping

With the patch no script should be executed and everything
should still work ok.

Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1649be1e9f510543f85b9e3a22af88ae8c6bfb9c)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit 845ee9282472f9a309b3af4aff49403b93091b19)
Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
---
 .../prog/en/modules/admin/fieldmapping.tt              | 10 +++++-----
 .../prog/en/modules/admin/items_search_fields.tt       |  4 ++--
 2 files changed, 7 insertions(+), 7 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt
index c295f25c90..06cd447d7a 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/fieldmapping.tt
@@ -24,18 +24,18 @@ $(document).ready(function() {
 	<div id="yui-main">
 		<div class="yui-b">
             <h2>Keyword to MARC mapping</h2>
-			[% UNLESS ( fields ) %]
-            <div class="dialog message"><p>There are no mappings for the [% IF framework.frameworktext %]<em>[% framework.frameworktext %]</em>[% ELSE %]default[% END %] framework. </p></div>
-			[% END %]
+            [% UNLESS ( fields.count ) %]
+                <div class="dialog message"><p>There are no mappings for the [% IF framework.frameworktext %]<em>[% framework.frameworktext |html %]</em>[% ELSE %]default[% END %] framework. </p></div>
+            [% END %]
 			<form method="get" action="/cgi-bin/koha/admin/fieldmapping.pl" id="selectframework">
 				<label for="framework">Framework:</label>
                 <select name="framework" id="framework" style="width:20em;">
                     <option value="">Default</option>
                 [% FOREACH f IN frameworks %]
                     [% IF f.frameworkcode == framework.frameworkcode %]
-                    <option selected="selected" value="[% f.frameworkcode %]">[% f.frameworktext %]</option>
+                    <option selected="selected" value="[% f.frameworkcode %]">[% f.frameworktext |html %]</option>
                     [% ELSE %]
-                    <option value="[% f.frameworkcode %]">[% f.frameworktext %]</option>
+                    <option value="[% f.frameworkcode %]">[% f.frameworktext |html %]</option>
                     [% END %]
                 [% END %]
                 </select>
diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt
index 7dd82e205b..2efc6a7124 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/items_search_fields.tt
@@ -77,8 +77,8 @@
                           <td>[% field.tagsubfield %]</td>
                           <td>[% field.authorised_values_category %]</td>
                           <td>
-                            <a class="btn btn-mini" href="/cgi-bin/koha/admin/items_search_field.pl?name=[% field.name %]" title="Edit [% field.name %] field"><i class="fa fa-pencil"></i> Edit</a>
-                            <a class="field-delete btn btn-mini" href="/cgi-bin/koha/admin/items_search_fields.pl?op=del&name=[% field.name %]"><i class="fa fa-trash"></i> Delete</a>
+                            <a class="btn btn-mini" href="/cgi-bin/koha/admin/items_search_field.pl?name=[% field.name |html %]" title="Edit [% field.name |html %] field"><i class="fa fa-pencil"></i> Edit</a>
+                            <a class="field-delete btn btn-mini" href="/cgi-bin/koha/admin/items_search_fields.pl?op=del&name=[% field.name |html %]"><i class="fa fa-trash"></i> Delete</a>
                           </td>
                         </tr>
                       [% END %]
-- 
2.39.5