From b647f01f51883a0e0596a9e66e9623af92b2ad62 Mon Sep 17 00:00:00 2001 From: Chris Nighswonger Date: Wed, 6 Oct 2010 23:31:57 -0400 Subject: [PATCH] Adding a temporary workaround to keep template tests from borking on very large templates NOTE: This should be properly fixed at some point in 3.4 This may help: http://www.perlmonks.org/?node_id=150748 Signed-off-by: Galen Charlton --- xt/author/valid-templates.t | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/xt/author/valid-templates.t b/xt/author/valid-templates.t index 95825a6bfa..df7c515918 100644 --- a/xt/author/valid-templates.t +++ b/xt/author/valid-templates.t @@ -69,11 +69,14 @@ sub gen_template_test { my $pid = open3(\*CHILD_IN, \*CHILD_OUT, \*CHILD_ERR, "$FindBin::Bin/test_template.pl", $File::Find::name, $include_dir); my @errors = (); + while () { + #FIXME: This is here just to ensure that STDOUT is read which avoids a deadlock in some instances, but probably not all + #FIXME: The real solution probably lies within the information found here: http://www.perlmonks.org/?node_id=150748 + } while () { push @errors, $_; } waitpid($pid, 0); - @errors = grep { ! /^EXPR:.*non-initialized variable/ } @errors; # ignoring EXPR errors for now my $rel_filename = File::Spec->abs2rel($File::Find::name); ok(@errors == 0, "no errors in $rel_filename") or diag(join("", @errors) ); -- 2.39.5