From b71531cd585b8b1288a57f47810659e31490f23c Mon Sep 17 00:00:00 2001 From: Jonathan Druart Date: Thu, 27 Oct 2022 10:53:06 +0200 Subject: [PATCH] Bug 32011: 2FA - Prevent qr_code to not be generated Caught by selenium/authentication_2fa.t # Failed test 'Enforce 2FA setup on first login' # at t/db_dependent/selenium/authentication_2fa.t line 291.Error while executing command: unexpected alert open: Dismissed user prompt dialog: [object Object] at /usr/share/perl5/Selenium/Remote/Driver.pm line 411. at /usr/share/perl5/Selenium/Remote/Driver.pm line 356. There is a 500 in the logs: "POST /api/v1/app.pl/api/v1/auth/two-factor/registration HTTP/1.1" 500 That is caused by [ERROR] POST /api/v1/auth/two-factor/registration: unhandled exception (Mojo::Exception)<> It's coming from GD::Barcode, in my understanding we should increase 'Version'. Test plan: Remove all other subtests from the selenium to speed up its exec, then run it in a loop. Without this patch the tests fail quite often (1/10), now it should not fail with this error (maybe another one, see bug 32010) Signed-off-by: Tomas Cohen Arazi (cherry picked from commit edb16022febc4968d172d6e3e96fac295d31579d) Signed-off-by: Lucas Gass --- Koha/Auth/TwoFactorAuth.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Auth/TwoFactorAuth.pm b/Koha/Auth/TwoFactorAuth.pm index 48b2a895ea..b3a0843cfb 100644 --- a/Koha/Auth/TwoFactorAuth.pm +++ b/Koha/Auth/TwoFactorAuth.pm @@ -99,7 +99,7 @@ sub qr_code { my $otpauth = $self->SUPER::qr_code( undef, undef, undef, 1); # no need to pass secret, key and issuer again - my $qrcode = GD::Barcode->new( 'QRcode', $otpauth, { Ecc => 'M', Version => 8, ModuleSize => 4 } ); + my $qrcode = GD::Barcode->new( 'QRcode', $otpauth, { Ecc => 'M', Version => 10, ModuleSize => 4 } ); my $data = $qrcode->plot->png; return "data:image/png;base64,". encode_base64( $data, q{} ); # does not contain newlines } -- 2.39.5