From cd8203d8d8ec6951a9061f94ddb06503110c8d62 Mon Sep 17 00:00:00 2001
From: arensb <arensb>
Date: Fri, 11 Oct 2002 12:36:44 +0000
Subject: [PATCH] Added FIXME comment. This file is obsolete, right?

---
 C4/Circulation.pm             |  2 ++
 C4/Circulation/Borrower.pm    | 27 +++++++++++++++++++++++++--
 C4/Interface/AccountsCDK.pm   |  3 +++
 C4/Interface/BorrowerCDK.pm   |  3 +++
 C4/Interface/FlagsCDK.pm      |  3 +++
 C4/Interface/RenewalsCDK.pm   |  3 +++
 C4/Interface/ReserveentCDK.pm |  3 +++
 C4/InterfaceCDK.pm            |  3 ++-
 8 files changed, 44 insertions(+), 3 deletions(-)

diff --git a/C4/Circulation.pm b/C4/Circulation.pm
index 8b99745428..07dcf98e2f 100755
--- a/C4/Circulation.pm
+++ b/C4/Circulation.pm
@@ -20,6 +20,8 @@ package C4::Circulation; #assumes C4/Circulation
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - This package is never used. Is it obsolete?
+
 use strict;
 require Exporter;
 use DBI;
diff --git a/C4/Circulation/Borrower.pm b/C4/Circulation/Borrower.pm
index 683e0ce97c..18fac931ec 100755
--- a/C4/Circulation/Borrower.pm
+++ b/C4/Circulation/Borrower.pm
@@ -21,6 +21,8 @@ package C4::Circulation::Borrower; #assumes C4/Circulation/Borrower
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - This module is never used. Obsolete?
+
 use strict;
 require Exporter;
 use DBI;
@@ -85,7 +87,7 @@ my $priv_func = sub {
 
 sub findborrower  {
   my ($env,$dbh) = @_;
-  C4::InterfaceCDK::helptext('');
+  C4::InterfaceCDK::helptext('');	# FIXME - This looks useless
   C4::InterfaceCDK::clearscreen();
   my $bornum = "";
   my $sth = "";
@@ -371,7 +373,28 @@ sub reserveslist {
   $sth->finish;
   reservesdisplay($env,$borrower,$amount,$odues,\@items);
 }
-  
+
+=item NewBorrowerNumber
+
+  $num = &NewBorrowerNumber();
+
+Allocates a new, unused borrower number, and returns it.
+
+=cut
+#'
+# FIXME - This is identical to C4::Search::NewBorrowerNumber.
+# Pick one (preferably this one) and stick with it.  
+
+# FIXME - Race condition: this function just says what the next unused
+# number is, but doesn't allocate it. Hence, two clients adding
+# patrons at the same time could get the same new borrower number and
+# clobber each other.
+# A better approach might be to change the database to make
+# borrowers.borrowernumber a unique key and auto_increment. Then, to
+# allocate a new borrower number, use "insert" to create a new record
+# (leaving the database daemon with the job of serializing requests),
+# and use the newly-created record.
+
 sub NewBorrowerNumber {
   my $dbh = C4::Context->dbh;
   my $sth=$dbh->prepare("Select max(borrowernumber) from borrowers");
diff --git a/C4/Interface/AccountsCDK.pm b/C4/Interface/AccountsCDK.pm
index 8efa16ed17..4a2557f20e 100755
--- a/C4/Interface/AccountsCDK.pm
+++ b/C4/Interface/AccountsCDK.pm
@@ -19,6 +19,9 @@ package C4::Interface::AccountsCDK; #asummes C4/Interface/AccountsCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I'm pretty sure that this, along with the rest of the
+# CDK-based stuff, is obsolete.
+
 use C4::InterfaceCDK;
 use C4::Accounts2;
 use strict;
diff --git a/C4/Interface/BorrowerCDK.pm b/C4/Interface/BorrowerCDK.pm
index 59a983654c..156d3ce9cc 100755
--- a/C4/Interface/BorrowerCDK.pm
+++ b/C4/Interface/BorrowerCDK.pm
@@ -19,6 +19,9 @@ package C4::Interface::BorrowerCDK; #asummes C4/Interface/BorrowerCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I'm pretty sure that this, along with the rest of the
+# CDK-based stuff, is obsolete.
+
 use C4::InterfaceCDK;
 use strict;
 use Cdk;
diff --git a/C4/Interface/FlagsCDK.pm b/C4/Interface/FlagsCDK.pm
index 523d446ff4..14876cb499 100755
--- a/C4/Interface/FlagsCDK.pm
+++ b/C4/Interface/FlagsCDK.pm
@@ -18,6 +18,9 @@ package C4::Interface::FlagsCDK; #asummes C4/Interface/FlagsCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I'm pretty sure that this, along with the rest of the
+# CDK-based stuff, is obsolete.
+
 use C4::Format;
 use C4::InterfaceCDK;
 use strict;
diff --git a/C4/Interface/RenewalsCDK.pm b/C4/Interface/RenewalsCDK.pm
index da7b7e4472..74be2bfead 100755
--- a/C4/Interface/RenewalsCDK.pm
+++ b/C4/Interface/RenewalsCDK.pm
@@ -19,6 +19,9 @@ package C4::Interface::RenewalsCDK; #assumes C4/Interface/RenewalsCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I'm pretty sure that this, along with the rest of the
+# CDK-based stuff, is obsolete.
+
 use strict;
 use Cdk;
 use C4::InterfaceCDK;
diff --git a/C4/Interface/ReserveentCDK.pm b/C4/Interface/ReserveentCDK.pm
index eeef7d7794..921b611a16 100755
--- a/C4/Interface/ReserveentCDK.pm
+++ b/C4/Interface/ReserveentCDK.pm
@@ -19,6 +19,9 @@ package C4::Interface::ReserveentCDK; #asummes C4/Interface/ReserveCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
+# FIXME - I'm pretty sure that this, along with the rest of the
+# CDK-based stuff, is obsolete.
+
 use C4::Format;
 use C4::InterfaceCDK;
 use strict;
diff --git a/C4/InterfaceCDK.pm b/C4/InterfaceCDK.pm
index bb3c413ab0..ce87b7f6ef 100755
--- a/C4/InterfaceCDK.pm
+++ b/C4/InterfaceCDK.pm
@@ -19,7 +19,8 @@ package C4::InterfaceCDK; #assumes C4/InterfaceCDK
 # Koha; if not, write to the Free Software Foundation, Inc., 59 Temple Place,
 # Suite 330, Boston, MA  02111-1307 USA
 
-# FIXME - This module doesn't compile!
+# FIXME - This module doesn't compile! But I'm pretty sure it, like
+# the rest of the CDK-based stuff, is obsolete.
 
 use C4::Format;
 use strict;
-- 
2.39.2