From da604a9006e86bf569f60ac3cd5b60d7e70447c2 Mon Sep 17 00:00:00 2001 From: Alex Buckley Date: Sat, 29 Sep 2018 05:24:22 +0000 Subject: [PATCH] Bug 21174: Open the OPAC cart with one click by default Feedback from the Koha mailing list in Aug 2018 showed there was widespread concensus for making the default behaviour of the OPAC cart to be to open with one click, rather than clicking on the cart icon then on the dropdown box to load the cart popup. This commit is a combination of Owen Leonard's alternative patch (slightly changing the markup in masthead.inc) and my work to remove the dropdown elements from the template and basket.js Test plan: 1. In Koha OPAC click on the cart icon (making sure to have items in the cart and the dropdown box 'Items in your cart:..' appears. 2. Click this dropdown and the cart popup appears. 3. Confirm you can successfully remove items from and empty the cart 4. Apply patch 5. Restart memcached, and plack 6. Click on the cart icon (making sure to have items in the cart) and notice no 'Items in your: ..' dropdown appears instead the cart popup loads straight away. 7. Confirm the items in your cart are displayed by the cart popup 8. Confirm you can remove items from/empty the cart, and that as you do this the number of cart items shown by the number to the right of the cart icon changes accordingly Sponsored-By: Toi Ohomai Institute of Technology, New Zealand Signed-off-by: Owen Leonard Signed-off-by: Jonathan Druart Signed-off-by: Katrin Fischer Signed-off-by: Nick Clemens --- .../opac-tmpl/bootstrap/en/includes/masthead.inc | 11 +++-------- koha-tmpl/opac-tmpl/bootstrap/js/basket.js | 5 ++--- 2 files changed, 5 insertions(+), 11 deletions(-) diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc index 6de2d19e5c..11628178a4 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc +++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/masthead.inc @@ -21,15 +21,10 @@ [% END %]
    [% IF ( Koha.Preference( 'opacbookbag' ) == 1 ) %] -
  • - - Cart +
  • + + Cart -
    • [% END %] [% IF ( Koha.Preference( 'virtualshelves' ) == 1 ) && ( Koha.Preference( 'opacbookbag' ) == 1 ) %] diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js index 250a0afa30..03e8e9e9b9 100644 --- a/koha-tmpl/opac-tmpl/bootstrap/js/basket.js +++ b/koha-tmpl/opac-tmpl/bootstrap/js/basket.js @@ -209,7 +209,6 @@ function addSelRecords(valSel) { // function for adding a selection of biblios t function showCartUpdate(msg){ // set body of popup window $("#cartDetails").html(msg); - $("#cartmenuitem").html(MSG_IN_YOUR_CART + " " + basketCount()); showCart(); setTimeout("hideCart()",2000); } @@ -507,8 +506,8 @@ function updateAllLinks(target){ } $("#cartDetails").ready(function(){ - $("#cartDetails,#cartmenuitem,#cartmenulink").on("click",function(){ hideCart(); }); - $("#cartmenuitem").click(function(e){ + $("#cartDetails,#cartmenulink").on("click",function(){ hideCart(); }); + $("#cartmenulink").click(function(e){ e.preventDefault(); openBasket(); $("li").closest().removeClass("open"); -- 2.39.5