From e9cba48c762ace72cb0dfa55d0007994fddaefcf Mon Sep 17 00:00:00 2001 From: Hammat Wele Date: Wed, 14 Jun 2023 17:20:00 +0000 Subject: [PATCH] Bug 33978: Adding authority from automatic linker closes imported record If you import a record, then create an authority record using the automatic linker, it closes the biblio record. The problem occures when a record is edited in a new tab. To recreate: 1. Import the example records 1.1. Download the example records 1.2. Go to Cataloging > Stage records for import 1.3. Choose the downloaded file 1.4. Click Upload file 1.5. Click Stage for import 1.6. Click View batch 1.7. Click Import this batch into the catalog 1.8. Click View detail of the enqueued job 1.9. Click Manage imported batch Correct behaviour: 2. In another tab, search for one of the records (for example, Fafounet) 3. Click Edit > Edit record 4. Go to field 100 5. Click Link authorities automatically --> It should say 100 - No matching authority found. 6. Click the plus sign next to 100 7. Fill out the mandatory fields by clinking in the text fields (000, 003, 005, 008, 040), field 100 should already be filled 8. Click 'Save' --> Authority number is added in 100 and you get to stay in the record for more edits if needed Incorrect behaviour: 9. Go back to the imported batch tab 10. Click Edit next to the second title (the one by Paventi, Eza) 11. Redo steps 4 to 8 --> Record is closedclear :( The behaviour should be the same, stay in the bibliographic record until it is saved. 12. Apply the patch 13. Redo step 9, 10, 4 14. Edit field 100, Type 'Paventi Test 2' 15. Redo step 5 to 8 --> Authority number is added in 100 and you get to stay in the record for more edits if needed Signed-off-by: Phil Ringnalda Signed-off-by: Katrin Fischer Signed-off-by: Tomas Cohen Arazi (cherry picked from commit ad124fe536aa11380bdce38b4dfc600864159477) Signed-off-by: Fridolin Somers (cherry picked from commit 03c5a75dfd6560eb30e0a6598d68ec015f6a073b) Signed-off-by: Pedro Amorim --- .../prog/en/modules/authorities/blinddetail-biblio-search.tt | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt index d72d51650c..8930da5d55 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/blinddetail-biblio-search.tt @@ -191,7 +191,9 @@ } } [% END %] - opener.close(); + if(opener.opener){ + opener.close(); + } window.close(); return false; }); -- 2.39.2