From eae49c6aca05ce3ce033c74ecdb7c001fa079d6f Mon Sep 17 00:00:00 2001
From: Nick Clemens <nick@bywatersolutions.com>
Date: Thu, 3 Dec 2020 17:03:40 +0000
Subject: [PATCH] Bug 27149: Unit tests

Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
(cherry picked from commit 1ae737603f3043c590e33e517d7d95ca8a8283ce)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
(cherry picked from commit de9bb3872d95d4e63fc9744d5d842bb811eee3c6)

Rebase fix

Signed-off-by: Andrew Fuerste-Henry <andrew@bywatersolutions.com>
---
 t/db_dependent/Koha/Z3950Responder/Session.t | 11 +++++++----
 1 file changed, 7 insertions(+), 4 deletions(-)

diff --git a/t/db_dependent/Koha/Z3950Responder/Session.t b/t/db_dependent/Koha/Z3950Responder/Session.t
index 33bfd4f527..9d845d9053 100644
--- a/t/db_dependent/Koha/Z3950Responder/Session.t
+++ b/t/db_dependent/Koha/Z3950Responder/Session.t
@@ -17,7 +17,7 @@ $schema->storage->txn_begin;
 
 subtest 'add_item_status' => sub {
 
-    plan tests => 2;
+    plan tests => 3;
 
     ## FIRST ITEM HAS ALL THE STATUSES ##
     my $item_1 = $builder->build({
@@ -30,8 +30,9 @@ subtest 'add_item_status' => sub {
             withdrawn => 1,
         }
     });
+    my ( $itemtag, $itemsubfield ) = C4::Biblio::GetMarcFromKohaField( "items.itemnumber" );
     my $item_marc_1 = C4::Items::GetMarcItem( $item_1->{biblionumber}, $item_1->{itemnumber} );
-    my $item_field_1 = scalar $item_marc_1->field('952');
+    my $item_field_1 = scalar $item_marc_1->field($itemtag);
     $builder->build({ source => 'Reserve', value=> { itemnumber => $item_1->{itemnumber} } });
     $builder->build({ source => 'Branchtransfer', value=> { itemnumber => $item_1->{itemnumber}, datearrived => undef } });
     ## END FIRST ITEM ##
@@ -48,8 +49,8 @@ subtest 'add_item_status' => sub {
         }
     });
     my $item_marc_2 = C4::Items::GetMarcItem( $item_2->{biblionumber}, $item_2->{itemnumber} );
-    my $item_field_2 = scalar $item_marc_2->field('952');
-    ## END SECOND ITEM ##
+    my $item_field_2 = scalar $item_marc_2->field($itemtag);
+   ## END SECOND ITEM ##
 
     # Create the responder
     my $args={ PEER_NAME => 'PEER'};
@@ -62,6 +63,8 @@ subtest 'add_item_status' => sub {
     $args->{HANDLE}->add_item_status($item_field_2);
     is($item_field_2->subfield('k'),'Available',"Available status added as expected");
 
+    is($item_field_2->subfield( $itemsubfield ), $item_2->{itemnumber}, "Itemnumber not removed when status added");
+
 };
 
 $schema->storage->txn_rollback;
-- 
2.39.5