From eccc2f25a9c8906e56d6f983ea28b5f3a5d9978e Mon Sep 17 00:00:00 2001 From: Yohann Dufour Date: Tue, 19 Aug 2014 11:02:47 +0200 Subject: [PATCH] Bug 12784: Patron cannot change his personal details MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch fixes the regression introduced by the bug 12623 : a patron cannot change his personal details from OPAC. Test plans : In order to test this patch, first you have to apply the patch of bug 12781 a1/ Login with a user in OPAC a2/ Request some modification (surname for example) a3/ Repeat 2/ a4/ There are no errors b1/ Register a new user from OPAC with the syspref : PatronSelfRegistrationVerifyByEmail with the value "Require" b2/ There are no errors Followed test plan. Patch behaves as expected. Signed-off-by: Marc Véron Signed-off-by: Katrin Fischer Patch works as expected, passes tests and QA script. Note: The second patron modification request of one patron will overwrite his/her first request. Signed-off-by: Tomas Cohen Arazi --- Koha/Borrower/Modifications.pm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Koha/Borrower/Modifications.pm b/Koha/Borrower/Modifications.pm index 00083fb7af..d01565518c 100644 --- a/Koha/Borrower/Modifications.pm +++ b/Koha/Borrower/Modifications.pm @@ -51,16 +51,18 @@ sub AddModifications { if( $self->{borrowernumber} ) { return if( not keys %$data ); $data->{borrowernumber} = $self->{borrowernumber}; + $data->{verification_token} = ''; } elsif( $self->{verification_token} ) { $data->{verification_token} = $self->{verification_token}; + $data->{borrowernumber} = 0; } else { return; } my $rs = Koha::Database->new()->schema->resultset('BorrowerModification'); - return $rs->update_or_create($data); + return $rs->update_or_create($data, { key => 'primary' } ); } =head2 Verify -- 2.39.5