From f0275e6677891be3467dbfa34340665ed97605ec Mon Sep 17 00:00:00 2001
From: Owen Leonard <oleonard@myacpl.org>
Date: Wed, 5 Aug 2020 17:27:58 +0000
Subject: [PATCH] Bug 26151: Remove the use of jquery.checkboxes plugin from
 suggestions management page

This patch removes the use of the jquery.checkboxes plugin from the
suggestions management page and replaces it with custom JS.

To test, apply the patch and go to Acquisitions -> Suggestions

Under each tab ("Accepted," "Pending," etc.), test that the "Check all"
and "Uncheck all" controls work correctly and only affect the table on
that tab.

Signed-off-by: Brandon J <brandon.jimenez@inLibro.com>

Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>

Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
---
 .../prog/en/modules/suggestion/suggestion.tt         | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
index 8930674422..5c5cf9a654 100644
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt
@@ -1024,8 +1024,6 @@
     [% IF op == 'else' %]
         [% INCLUDE 'datatables.inc' %]
         [% INCLUDE 'columns_settings.inc' %]
-        [% Asset.js("lib/jquery/plugins/jquery.checkboxes.min.js") | $raw %]
-
         <script>
             $(document).ready(function() {
                 $('#suggestiontabs').tabs();
@@ -1050,13 +1048,15 @@
 
                 $(".checkall").click(function(e){
                     e.preventDefault();
-                    $(this).parents('form').checkCheckboxes();
-                    return false;
+                    $(this).parents('form').find("input:checkbox").each(function(){
+                        $(this).prop("checked", true);
+                    });
                 });
                 $(".uncheckall").click(function(e){
                     e.preventDefault();
-                    $(this).parents('form').unCheckCheckboxes();
-                    return false;
+                    $(this).parents('form').find("input:checkbox").each(function(){
+                        $(this).prop("checked", false);
+                    });
                 });
                 $(".other_reason").hide();
                 $("select[name='reason']").change(function(){
-- 
2.39.2