From f4eca02d0a7a7e831c1a4eca5e39c73a1695b5df Mon Sep 17 00:00:00 2001 From: Owen Leonard Date: Tue, 2 Jun 2020 11:08:23 +0000 Subject: [PATCH] Bug 25582: Don't show OPAC problems entry on dashboard when there are no reports This patch makes a minor correction to the template to correct the check on outstanding OPAC problem reports. An error was preventing the check from working correctly. To test, apply the patch and enable the OPACReportProblem system preference. - On the staff interface home page, check the area showing pending operations (suggestions, tags, etc.). - If you have no pending OPAC problem reports there should be no line for OPAC problem reports. - If necessary, mark all pending OPAC problem reports closed and confirm that when there are no outstanding reports the link is hidden. - Also test when there are no other outstanding reports in that section (suggestions, tags, patron modifications), nothing appears at all, not even the surrounding border. - If necessary, test that the link appears when you have one or more OPAC problem reports. - Go to the OPAC and use the "Report a problem" to submit a test report. - Check that the staff interface home page reflects that there is now a pending report. Signed-off-by: David Nind Signed-off-by: Katrin Fischer Signed-off-by: Jonathan Druart (cherry picked from commit a17c0475d8fff517eaf3a0da6dfaa65d43bde9f3) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt index 1ec2e3d852..fbf727b6ef 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/intranet-main.tt @@ -134,7 +134,7 @@
[%# Following statement must be in one line for translatability %] - [% IF ( CAN_user_tools_moderate_comments && pendingcomments ) || ( CAN_user_tools_moderate_tags && pendingtags ) || ( CAN_user_borrowers_edit_borrowers && pending_borrower_modifications ) || ( CAN_user_suggestions_suggestions_manage && pendingsuggestions ) || ( CAN_user_borrowers_edit_borrowers && pending_discharge_requests ) || pending_article_requests || ( Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes && pending_checkout_notes.count ) || ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports ) %] + [% IF ( CAN_user_tools_moderate_comments && pendingcomments ) || ( CAN_user_tools_moderate_tags && pendingtags ) || ( CAN_user_borrowers_edit_borrowers && pending_borrower_modifications ) || ( CAN_user_suggestions_suggestions_manage && pendingsuggestions ) || ( CAN_user_borrowers_edit_borrowers && pending_discharge_requests ) || pending_article_requests || ( Koha.Preference('AllowCheckoutNotes') && CAN_user_circulate_manage_checkout_notes && pending_checkout_notes.count ) || ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports.count ) %]
[% IF pending_article_requests %]
@@ -188,7 +188,7 @@
[% END %] - [% IF ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports ) %] + [% IF ( Koha.Preference('OPACReportProblem') && CAN_user_problem_reports && pending_problem_reports.count ) %]
OPAC problem reports pending: [% pending_problem_reports.count | html %] -- 2.39.5