From f92f6a315d8b89a7da65cb24f85edea2963ecbfe Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Tue, 12 Jul 2022 18:39:06 +0000 Subject: [PATCH] Bug 31144: When modifying an order we should not load the vendor default discount After placing an order in a basket with a discount of "0" if you attempt to modify we will load the vendor default discount, this can lead to accidentally applying a discount when modifying other order parts To test: 0 - Have a vendor with a discount set 1 - Add an order to a basket 2 - While adding, set discount to 0 3 - Add order - prices are calculated ocrrectly 4 - Modify order 5 - Note discount is populated with vendor discount 6 - Cancel 7 - Apply patch 8 - Modify order 9 - Discount remains at 0 10 - Repeat with a vendor with no discount set 11 - Placing order not specifiying discount it remains blank 12 - Modifying order discount remains blank 13 - Modify order and set discount 14 - Confirm it is retained on modifcation Signed-off-by: Kelly McElligott Signed-off-by: Martin Renvoize Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 73d2066837e5f73e44c89952497d12e6f1d13342) Signed-off-by: Lucas Gass --- koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt index 468e93c0a7..13a47cb960 100644 --- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt +++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt @@ -446,7 +446,7 @@ [% END %]
  • - [% IF ( orderdiscount ) %] + [% IF ( ordernumber ) %] % [% ELSE %] % -- 2.39.5