From fbde769aec127ab899a52197d9c0b176c54b87c4 Mon Sep 17 00:00:00 2001 From: Nick Clemens Date: Thu, 6 Oct 2022 19:13:10 +0000 Subject: [PATCH] Bug 31421: Do not apply library limits to Categories plugin This patch simply changes from using 'search_with_library_limits' to 'search' The limits I think are intended to prevent users from setting a patron to the wrong category, they are not meant to hide patrons. Or rather, they don't do that, patrons are returned in search but cannot be processed. The dropdowns as well won't contain the category, so you can see these patrons, but not filter by the category Bug 31422 and bug 31032 point out further issues with limits. For now, let's fix searching To test: 1 - Edit Patron category 'Patron/PT' 2 - Try to do a patron search that returns patrons in this category 3 - See 'Processing' and error in JS console: Uncaught TypeError: categories_map[data] is undefined 4 - Apply patch 5 - Restart all and repeate 6 - It works now! Signed-off-by: David Nind Signed-off-by: Jonathan Druart Signed-off-by: Tomas Cohen Arazi (cherry picked from commit 29754226ea3b6bdaf896e5b8d19f44b1ed551e11) Signed-off-by: Lucas Gass --- Koha/Template/Plugin/Categories.pm | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Koha/Template/Plugin/Categories.pm b/Koha/Template/Plugin/Categories.pm index db7b2fd0e2..198690406c 100644 --- a/Koha/Template/Plugin/Categories.pm +++ b/Koha/Template/Plugin/Categories.pm @@ -25,7 +25,7 @@ use Koha::Patron::Categories; sub all { my ( $self, $params ) = @_; - return Koha::Patron::Categories->search_with_library_limits($params); + return Koha::Patron::Categories->search($params); } sub GetName { -- 2.39.5