]> git.koha-community.org Git - koha.git/commit
Bug 12076: better detect an untranslatable template construct
authorGalen Charlton <gmc@esilibrary.com>
Fri, 11 Apr 2014 18:49:07 +0000 (18:49 +0000)
committerKyle M Hall <kyle@bywatersolutions.com>
Wed, 13 Aug 2014 14:01:11 +0000 (10:01 -0400)
commit768481e7d7d4ec648b24df47f6e68e18b7366781
treedf5e280e76e61c110b03fe1d442a2c914e8cfaf0
parentea8d10c3d32201e2da972bb0b1a8fb37a00506d7
Bug 12076: better detect an untranslatable template construct

Per bug 6458, template constructs of the form

<li [% IF (foo) %]selected="selected"[% END %]...

are forbidden as they can cause problems with translated templates.
However, the tt_valid.t test currently doesn't catch the variation
where '-' is used to suppress extra whitespace:

<li [%- IF (foo) -%]selected="selected"[%- END -%]...

This patch corrects the issue.

To test:

[1] Temporarily add the following line to a template file:

<li [%- IF a -%]a="a"[%- END -%] />

[2] Run prove -v xt/tt_valid.t.  Note that no error is reported.
[3] Apply the patch, and rerun the tt_valid.t test.  This time,
    an error should be reported.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
Signed-off-by: Bernardo Gonzalez Kriegel <bgkriegel@gmail.com>
Works well, detects the forbidden pattern
No koha-qa errors.

Signed-off-by: Katrin Fischer <Katrin.Fischer.83@web.de>
Works as described, passes all tests and QA script.

Signed-off-by: Galen Charlton <gmc@esilibrary.com>
(cherry picked from commit 9a7eedce78af128772a36b5a16416fdad1a16fcc)
Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com>
Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
(cherry picked from commit a7b28d19a71f16ebad3805139e7f82f268d77c5c)
xt/tt_valid.t