From b646d8ab651e32067367a8ba781fc4256b9eec68 Mon Sep 17 00:00:00 2001
From: Matt Blenkinsop <matt.blenkinsop@ptfs-europe.com>
Date: Wed, 17 Jul 2024 08:36:16 +0000
Subject: [PATCH] Bug 37288: Improve display of data provider edit form

This patch makes some improvements to the edit form for data providers. It delays page display until the counter registry has responded and also improves the display of the "create manually" and "Create from registry" buttons

Test plan:
1) Create a Data provider in the ERM module
2) Click to edit that new provider
3) The page will load and there will be a slight delay before the Data provider name input is populated
4) The "Create manually" button will also be visible
5) Apply patch and yarn build
6) Hard refresh the browser and repeat steps 1 and 2
7) This time when the page loads the provider name should be prepopulated and no manual creation button will be visible

Signed-off-by: David Nind <david@davidnind.com>
Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de>
---
 .../ERM/UsageStatisticsDataProvidersFormAdd.vue      | 12 +++++++++---
 1 file changed, 9 insertions(+), 3 deletions(-)

diff --git a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
index a935459249..8311922e2b 100644
--- a/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
+++ b/koha-tmpl/intranet-tmpl/prog/js/vue/components/ERM/UsageStatisticsDataProvidersFormAdd.vue
@@ -59,7 +59,10 @@
                             </v-select>
                             <span class="required">{{ $__("Required") }}</span>
                             <button
-                                v-if="!manual_form"
+                                v-if="
+                                    !manual_form &&
+                                    !usage_data_provider.erm_usage_data_provider_id
+                                "
                                 type="button"
                                 style="margin-left: 1em"
                                 @click="createManualProvider()"
@@ -67,7 +70,10 @@
                                 {{ $__("Create manually") }}
                             </button>
                             <button
-                                v-else
+                                v-if="
+                                    manual_form &&
+                                    !usage_data_provider.erm_usage_data_provider_id
+                                "
                                 type="button"
                                 style="margin-left: 1em"
                                 @click="createFromRegistry()"
@@ -440,7 +446,6 @@ export default {
                     this.usage_data_provider.report_types =
                         this.formatReportTypes(usage_data_provider.report_types)
                     this.getCounterRegistry(usage_data_provider.name, "edit")
-                    this.initialized = true
                 },
                 error => {}
             )
@@ -463,6 +468,7 @@ export default {
                             )
                     }
                     this.searching = false
+                    this.initialized = true
                 },
                 error => {}
             )
-- 
2.39.5