]> git.koha-community.org Git - koha.git/commit
Bug 9421: tools/picture-upload.pl not Plack-compatible
authorJared Camins-Esakov <jcamins@cpbibliography.com>
Fri, 18 Jan 2013 02:39:38 +0000 (21:39 -0500)
committerChris Cormack <chris@bigballofwax.co.nz>
Fri, 8 Feb 2013 23:22:55 +0000 (12:22 +1300)
commit05b642086daf05c0f3669bae48287de71c905306
tree08cdc08b64af38590a43cc50b0384af88ebce36a
parentc96997420bcbfc9040447587266fd769d6afe622
Bug 9421: tools/picture-upload.pl not Plack-compatible

This patch avoids using file-level private variables in subroutines
by passing the needed variables as parameters to the subroutines.

To test (under Plack):
1) Try uploading a patron image without applying the patch. Notice
   it fails.
2) Apply patch.
3) Try uploading a patron image again, noticing this time it succeeds.

To test (under Apache):
1) Apply patch.
2) Try uploading a patron image, confirm that it works.

Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net>
Fixes Plack, does not break Apache. Works as expected.

Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
Signed-off-by: Jared Camins-Esakov <jcamins@cpbibliography.com>
Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz>
tools/picture-upload.pl