From 5079a9cb663963f29e1ebb7f91431df6794d6f3e Mon Sep 17 00:00:00 2001 From: Martin Renvoize Date: Wed, 19 May 2021 09:37:35 +0100 Subject: [PATCH] Bug 28382: Set trigger to 'Reserve' when actioning a reserve transfer MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit This patch sets the transfer trigger to 'Reserve' when the staff user confirms they are transfering to fulfil a reserve. Test plan 1 - Place a hold for delivery at Library B 2 - Sign in at Library A 3 - Browse to Circulation->Transfers 4 - Attempt to transfer an item on the title with the hold to Library B 5 - You get a notice that hold was found 6 - You have the option transfer the for the hold - click it 7 - Confirm hold is set to transit and transfer generated 8 - Check the branchtransfers table and confirm the 'reason' is 'Reserve' not 'Manual'. Signed-off-by: David Nind JK: fix typo resver -> reserve Signed-off-by: Joonas Kylmälä Signed-off-by: Jonathan Druart Signed-off-by: Kyle M Hall --- circ/branchtransfers.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/circ/branchtransfers.pl b/circ/branchtransfers.pl index ca14276e09..9a652750de 100755 --- a/circ/branchtransfers.pl +++ b/circ/branchtransfers.pl @@ -82,6 +82,7 @@ my $settransit; my $request = $query->param('request') || ''; my $borrowernumber = $query->param('borrowernumber') || 0; my $tobranchcd = $query->param('tobranchcd') || ''; +my $trigger = 'Manual'; my $ignoreRs = 0; ############ @@ -105,6 +106,7 @@ elsif ( $request eq "SetTransit" ) { $ignoreRs = 1; $settransit = 1; $reqmessage = 1; + $trigger = 'Reserve'; } elsif ( $request eq 'KillReserved' ) { my $biblionumber = $query->param('biblionumber'); @@ -132,7 +134,7 @@ if ($barcode) { to_branch => $tobranchcd, barcode => $barcode, ignore_reserves => $ignoreRs, - trigger => 'Manual' + trigger => $trigger }); my $item = Koha::Items->find({ barcode => $barcode }); $found = $messages->{'ResFound'} unless $settransit; -- 2.39.5