From 76c3649db32b408eb19f7356eabf001d0745edef Mon Sep 17 00:00:00 2001 From: Fridolyn SOMERS Date: Wed, 13 Feb 2013 10:29:15 +0100 Subject: [PATCH] Bug 9605: rotating collections permissions are wrong In tools / rotating collections, permissions are 'parameters => 1'. But there is a dedicated permission : tools => rotating_collections. Test plan : - Disable tools/rotating_collections permission to your connected user - Check you dont have access to those pages : rotating_collections/addItems.pl rotating_collections/editCollections.pl rotating_collections/rotatingCollections.pl rotating_collections/transferCollection.pl - Enable tools/rotating_collections permission to your connected user - Check you have access to above pages Signed-off-by: Kyle M Hall Signed-off-by: Katrin Fischer Fixes wrong permission on rotating collection related pages. This will allow to block access to those. Signed-off-by: Jared Camins-Esakov --- rotating_collections/addItems.pl | 2 +- rotating_collections/editCollections.pl | 2 +- rotating_collections/rotatingCollections.pl | 2 +- rotating_collections/transferCollection.pl | 2 +- 4 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rotating_collections/addItems.pl b/rotating_collections/addItems.pl index ae7070f866..06b6b3a8a7 100755 --- a/rotating_collections/addItems.pl +++ b/rotating_collections/addItems.pl @@ -34,7 +34,7 @@ my ($template, $loggedinuser, $cookie) query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => {parameters => 1}, + flagsrequired => { tools => 'rotating_collections' }, debug => 1, }); diff --git a/rotating_collections/editCollections.pl b/rotating_collections/editCollections.pl index 4c4849c000..e38660864e 100755 --- a/rotating_collections/editCollections.pl +++ b/rotating_collections/editCollections.pl @@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie) query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => {parameters => 1}, + flagsrequired => { tools => 'rotating_collections' }, debug => 1, }); diff --git a/rotating_collections/rotatingCollections.pl b/rotating_collections/rotatingCollections.pl index 52ee5ee460..35aea56977 100755 --- a/rotating_collections/rotatingCollections.pl +++ b/rotating_collections/rotatingCollections.pl @@ -33,7 +33,7 @@ my ($template, $loggedinuser, $cookie) query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => {parameters => 1}, + flagsrequired => { tools => 'rotating_collections' }, debug => 1, }); diff --git a/rotating_collections/transferCollection.pl b/rotating_collections/transferCollection.pl index 39945d5792..23eff46afd 100755 --- a/rotating_collections/transferCollection.pl +++ b/rotating_collections/transferCollection.pl @@ -38,7 +38,7 @@ my ($template, $loggedinuser, $cookie) query => $query, type => "intranet", authnotrequired => 0, - flagsrequired => {parameters => 1}, + flagsrequired => { tools => 'rotating_collections' }, debug => 1, }); -- 2.39.5